LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] x86: GEODE: add missing module.h include
       [not found] ` <20080326175622.GB32151@cosmic.amd.com>
@ 2008-03-26 18:13   ` Andres Salomon
  0 siblings, 0 replies; only message in thread
From: Andres Salomon @ 2008-03-26 18:13 UTC (permalink / raw)
  To: Jordan Crouse
  Cc: Stefan Pfetzing, linux-kernel, akpm, mingo, hpa, Thomas Gleixner

On Wed, 26 Mar 2008 11:56:22 -0600
Jordan Crouse <jordan.crouse@amd.com> wrote:

> On 26/03/08 14:31 +0100, Stefan Pfetzing wrote:
> > Hello Jordan,
> >
> > I just tried to build your geodwdt driver for the geode watchdog. Therefore 
> > I pulled your repository from http://git.infradead.org/geode.git (or more, 
> > the git url).
> >
> > I tried to build the geodewdt driver as a module - which didn't work, and 
> > it failed with the same problem as earlier mentioned on lkmk [1]. I also 
> > checked the fix [2], but that seems to be already in your (or linus) tree - 
> > and so I'm unsure what the problem is.
> >
> > [1] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884074
> > [2] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884174
> >
> > Building directly into the kernel seems to work.
> >
> > Maybe you have some idea?
> 
> Hmm - that is strange.  Exporting the symbols should work.  I recommend
> starting over with a clean tree.
> 
> CCing Andres - any thoughts?
> 
> Jordan
> 


Er, yeah.  The patch below should fix it.  This should probably go into
2.6.25.





Oops, EXPORT_SYMBOL_GPL wasn't being declared due to this header
being missing.

Signed-off-by: Andres Salomon <dilinger@debian.org>
---
 arch/x86/kernel/mfgpt_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mfgpt_32.c b/arch/x86/kernel/mfgpt_32.c
index 3f0f603..2c0e6b5 100644
--- a/arch/x86/kernel/mfgpt_32.c
+++ b/arch/x86/kernel/mfgpt_32.c
@@ -30,6 +30,7 @@
 
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <asm/geode.h>
 
 static struct mfgpt_timer_t {
-- 
1.5.3.7


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-26 18:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <88C5E610-F4BD-48FC-8673-D99D11C205D6@dreamind.de>
     [not found] ` <20080326175622.GB32151@cosmic.amd.com>
2008-03-26 18:13   ` [PATCH] x86: GEODE: add missing module.h include Andres Salomon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).