LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com> To: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] init: move setup of nr_cpu_ids to as early as possible v3 Date: Wed, 26 Mar 2008 14:23:48 -0700 [thread overview] Message-ID: <20080326212347.654559000@polaris-admin.engr.sgi.com> (raw) In-Reply-To: 20080326212347.466221000@polaris-admin.engr.sgi.com [-- Attachment #1: setup-nr_cpu_ids --] [-- Type: text/plain, Size: 2477 bytes --] Move the setting of nr_cpu_ids from sched_init() to start_kernel() so that it's available as early as possible. Note that an arch has the option of setting it even earlier if need be, but it should not result in a different value than the setup_nr_cpu_ids() function. Based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git Signed-off-by: Mike Travis <travis@sgi.com> --- init/main.c | 17 +++++++++++++++++ kernel/sched.c | 7 ------- 2 files changed, 17 insertions(+), 7 deletions(-) --- linux.trees.git.orig/init/main.c +++ linux.trees.git/init/main.c @@ -360,10 +360,26 @@ static void __init smp_init(void) #endif static inline void setup_per_cpu_areas(void) { } +static inline void setup_nr_cpu_ids(void) { } static inline void smp_prepare_cpus(unsigned int maxcpus) { } #else +/* Setup number of possible processor ids */ +int nr_cpu_ids __read_mostly = NR_CPUS; +EXPORT_SYMBOL(nr_cpu_ids); + +/* An arch may set nr_cpu_ids earlier if needed, so this would be redundant */ +static void __init setup_nr_cpu_ids(void) +{ + int cpu, highest_cpu = 0; + + for_each_possible_cpu(cpu) + highest_cpu = cpu; + + nr_cpu_ids = highest_cpu + 1; +} + #ifndef CONFIG_HAVE_SETUP_PER_CPU_AREA unsigned long __per_cpu_offset[NR_CPUS] __read_mostly; @@ -544,6 +560,7 @@ asmlinkage void __init start_kernel(void setup_command_line(command_line); unwind_setup(); setup_per_cpu_areas(); + setup_nr_cpu_ids(); smp_prepare_boot_cpu(); /* arch-specific boot-cpu hooks */ /* --- linux.trees.git.orig/kernel/sched.c +++ linux.trees.git/kernel/sched.c @@ -5923,10 +5923,6 @@ void __init migration_init(void) #ifdef CONFIG_SMP -/* Number of possible processor ids */ -int nr_cpu_ids __read_mostly = NR_CPUS; -EXPORT_SYMBOL(nr_cpu_ids); - #ifdef CONFIG_SCHED_DEBUG static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level) @@ -7152,7 +7148,6 @@ static void init_tg_rt_entry(struct rq * void __init sched_init(void) { - int highest_cpu = 0; int i, j; #ifdef CONFIG_SMP @@ -7207,7 +7202,6 @@ void __init sched_init(void) #endif init_rq_hrtick(rq); atomic_set(&rq->nr_iowait, 0); - highest_cpu = i; } set_load_weight(&init_task); @@ -7217,7 +7211,6 @@ void __init sched_init(void) #endif #ifdef CONFIG_SMP - nr_cpu_ids = highest_cpu + 1; open_softirq(SCHED_SOFTIRQ, run_rebalance_domains, NULL); #endif --
next prev parent reply other threads:[~2008-03-26 21:25 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-26 21:23 [PATCH 0/2] generic: simplify setup_nr_cpu_ids and add set_cpus_allowed_ptr Mike Travis 2008-03-26 21:23 ` Mike Travis [this message] 2008-03-26 21:23 ` [PATCH 2/2] sched: add new set_cpus_allowed_ptr function Mike Travis 2008-03-27 9:01 ` [PATCH 0/2] generic: simplify setup_nr_cpu_ids and add set_cpus_allowed_ptr Ingo Molnar -- strict thread matches above, loose matches on Subject: below -- 2008-02-19 20:32 [PATCH 0/2] percpu: Optimize percpu accesses v3 Mike Travis 2008-02-19 20:32 ` [PATCH 1/2] init: move setup of nr_cpu_ids to as early as possible v3 Mike Travis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080326212347.654559000@polaris-admin.engr.sgi.com \ --to=travis@sgi.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@elte.hu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).