LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 0/4, v11] PCI, ACPI: Physical PCI slot objects
@ 2008-03-25  4:13 Alex Chiang
  2008-03-25  4:15 ` [PATCH 1/4] Construct one fakephp slot per pci slot Alex Chiang
                   ` (3 more replies)
  0 siblings, 4 replies; 15+ messages in thread
From: Alex Chiang @ 2008-03-25  4:13 UTC (permalink / raw)
  To: Kenji Kaneshige
  Cc: Greg KH, Gary Hade, Kristen Carlson Accardi, Matthew Wilcox,
	warthog19, rick.jones2, linux-kernel, linux-pci, linux-acpi

Hi Greg, Kenji-san,

* Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>:
> I've reviewed and tested the latest version of Alex's
> "introduce pci_slot" series [and] I found some bugs and some
> codes need to be changed.

First, many thanks to Kenji-san for his code review and
subsequent patches. They really improved the code a lot!

I've merged all his changes into my series, with the thought that
it will be better to contain all the fixes in one spot for future
bisectability purposes.

I gave Kenji-san credit in the changelog, as well at the top of
drivers/acpi/pci_slot.c, but if that's not sufficient, we can
certainly add more attributions where it's appropriate. Please
let me know.

This is v11 of the physical pci_slot series. It should be *very*
close to what I'd like to see in linux-next for further testing.
I would appreciate any final code review and if it looks ok,
maybe finally get it merged upstream. ;)

Thanks to all testers, reviewers, and commenters.

/ac


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH 0/4, v12] PCI, ACPI: Physical PCI slot objects
@ 2008-03-25 17:09 Alex Chiang
  2008-03-25 17:13 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Chiang @ 2008-03-25 17:09 UTC (permalink / raw)
  To: gregkh
  Cc: Gary Hade, Kenji Kaneshige, Kristen Carlson Accardi,
	Matthew Wilcox, warthog19, rick.jones2, linux-kernel, linux-pci,
	linux-acpi

Hi Greg,

This is v12 of the physical pci_slot series.

I had to do one last respin because I misspelled Kenji-san's name
in the changelog. I've also added his Acked-by.

There are no code changes between v11 and v12.

Sorry for the noise.

Thanks.

/ac


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH 0/4, v7] PCI, ACPI: Physical PCI slot objects
@ 2008-02-29  0:23 Alex Chiang
  2008-02-29  0:28 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Chiang @ 2008-02-29  0:23 UTC (permalink / raw)
  To: Gary Hade, kaneshige.kenji, warthog19
  Cc: Matthew Wilcox, gregkh, kristen.c.accardi, rick.jones2,
	linux-kernel, linux-pci, linux-acpi

Hi Gary, John, Kenji-san, et. al,

Well, first Gary was on holiday for a month, and then I was on
holiday for a month, but I'm back now, and have refreshed this
patch series against 2.6.25.

The major thing that happened was all the kobject changes
(learned my lesson about taking long holidays when holding onto a
largish chunk of code that hasn't been accepted yet ;), and so
the only real change is in patch 3/4.

The kobject changes were nice, btw. In the prior versions of this
series, I could never figure out why my kobjects weren't getting
released when their refcounts went to 1, and had some hacky code
in there to manually release them. (I'm sure I was doing
something wrong, but I couldn't figure out what.) I was able to
remove that hack in this series because the kobjects are working
the way they're supposed to.

I did turn on kobject debugging, and all seems well except for
one little thing. I based my module (pci_slot) on acpiphp, and
the kobject system complains:

kobject: 'acpiphp' (a00000020476aed0): does not have a release()
function, it is broken and must be fixed.

kobject: 'pci_slot' (a000000204791e50): does not have a release()
function, it is broken and must be fixed.

Not quite sure what to do about these yet, but since no one has
fixed acpiphp yet, I'm thinking that I can't be *too* wrong. :)

I'm *hoping* that my misunderstanding of kobjects last time
around is what caused the weirdness on Gary's machine, and that
we won't see any more problems.

I've tested this series on my hp rx6600 with both acpiphp and
pciehp drivers, and as before, any and all combinations of those
modules can be modprobe'd/rmmod'ed in any order, etc.

I'd love to see some more testing of this, and then (hopefully!)
upstream acceptance.

Thanks!

/ac


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2008-03-28 18:00 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-25  4:13 [PATCH 0/4, v11] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-03-25  4:15 ` [PATCH 1/4] Construct one fakephp slot per pci slot Alex Chiang
2008-03-25  4:16 ` [PATCH 2/4] Export kobject_rename for pci_hotplug_core Alex Chiang
2008-03-25  4:17 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
2008-03-25  4:49   ` Kenji Kaneshige
2008-03-28 10:39   ` Andrew Morton
2008-03-28 15:41     ` Alex Chiang
2008-03-28 17:56       ` Andrew Morton
2008-03-25  4:17 ` [PATCH 4/4] ACPI PCI slot detection driver Alex Chiang
2008-03-25  4:50   ` Kenji Kaneshige
  -- strict thread matches above, loose matches on Subject: below --
2008-03-25 17:09 [PATCH 0/4, v12] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-03-25 17:13 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
2008-02-29  0:23 [PATCH 0/4, v7] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-02-29  0:28 ` [PATCH 3/4] Introduce pci_slot Alex Chiang
2008-03-01  5:24   ` Greg KH
2008-03-03 20:56     ` Alex Chiang
2008-03-04  5:58       ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).