LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
@ 2008-03-30 22:40 Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2008-03-30 22:40 UTC (permalink / raw)
To: linux-kernel
Every file should include the headers containing the externs its global
code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 17 Feb 2008
b6f818ea9e2dd76d3fd7dbec2382240cabe66a6b diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fa3a3d 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/poll.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
2008-04-21 22:43 ` Alexey Dobriyan
@ 2008-04-22 19:41 ` Alexey Dobriyan
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Dobriyan @ 2008-04-22 19:41 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Tue, Apr 22, 2008 at 02:43:14AM +0400, Alexey Dobriyan wrote:
> On Tue, Apr 22, 2008 at 12:32:09AM +0300, Adrian Bunk wrote:
> > Every file should include the headers containing the externs its global
> > code.
>
> Declaration should be moved to fs/proc/internal.h and included from
> there.
I wrote basically the same in February, what's up?
http://marc.info/?l=linux-kernel&m=120324267808331&w=2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
2008-04-21 21:32 Adrian Bunk
@ 2008-04-21 22:43 ` Alexey Dobriyan
2008-04-22 19:41 ` Alexey Dobriyan
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Dobriyan @ 2008-04-21 22:43 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Tue, Apr 22, 2008 at 12:32:09AM +0300, Adrian Bunk wrote:
> Every file should include the headers containing the externs its global
> code.
Declaration should be moved to fs/proc/internal.h and included from
there.
> --- a/fs/proc/kmsg.c
> +++ b/fs/proc/kmsg.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/poll.h>
> #include <linux/fs.h>
> +#include <linux/proc_fs.h>
No, really. Such included tend to stick forever, so let's do right thing
from beginning.
It would be nice if your scripts put at least some names of
relevant globals into changelog.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
@ 2008-04-21 21:32 Adrian Bunk
2008-04-21 22:43 ` Alexey Dobriyan
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2008-04-21 21:32 UTC (permalink / raw)
To: linux-kernel
Every file should include the headers containing the externs its global
code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 14 Apr 2008
- 31 Mar 2008
- 17 Feb 2008
b6f818ea9e2dd76d3fd7dbec2382240cabe66a6b diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fa3a3d 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/poll.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
@ 2008-04-14 18:13 Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:13 UTC (permalink / raw)
To: linux-kernel
Every file should include the headers containing the externs its global
code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 31 Mar 2008
- 17 Feb 2008
b6f818ea9e2dd76d3fd7dbec2382240cabe66a6b diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fa3a3d 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/poll.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
2008-02-17 8:20 Adrian Bunk
@ 2008-02-17 10:03 ` Alexey Dobriyan
0 siblings, 0 replies; 7+ messages in thread
From: Alexey Dobriyan @ 2008-02-17 10:03 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sun, Feb 17, 2008 at 10:20:48AM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the externs its global
> code (in this case for struct proc_kmsg_operations).
It should be moved to fs/proc/internal.h to where it belongs.
> --- a/fs/proc/kmsg.c
> +++ b/fs/proc/kmsg.c
> @@ -11,6 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/poll.h>
> #include <linux/fs.h>
> +#include <linux/proc_fs.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>
@ 2008-02-17 8:20 Adrian Bunk
2008-02-17 10:03 ` Alexey Dobriyan
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2008-02-17 8:20 UTC (permalink / raw)
To: linux-kernel
Every file should include the headers containing the externs its global
code (in this case for struct proc_kmsg_operations).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
b6f818ea9e2dd76d3fd7dbec2382240cabe66a6b diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index ff3b90b..9fa3a3d 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -11,6 +11,7 @@
#include <linux/kernel.h>
#include <linux/poll.h>
#include <linux/fs.h>
+#include <linux/proc_fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-04-22 18:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-30 22:40 [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h> Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2008-04-21 21:32 Adrian Bunk
2008-04-21 22:43 ` Alexey Dobriyan
2008-04-22 19:41 ` Alexey Dobriyan
2008-04-14 18:13 Adrian Bunk
2008-02-17 8:20 Adrian Bunk
2008-02-17 10:03 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).