LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* firmware_sample_driver.c: fix coding style
@ 2008-04-01 10:55 Pavel Machek
2008-04-21 21:49 ` Jesper Juhl
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2008-04-01 10:55 UTC (permalink / raw)
To: kernel list, Andrew Morton, Trivial patch monkey
Fix coding style in firmware_sample_driver...
Signed-off-by: Pavel Machek <pavel@suse.cz>
diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c
index 6865cbe..600cdd9 100644
--- a/Documentation/firmware_class/firmware_sample_driver.c
+++ b/Documentation/firmware_class/firmware_sample_driver.c
@@ -34,8 +34,7 @@ static void sample_probe_default(void)
const struct firmware *fw_entry;
printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
- if(request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0)
- {
+ if (request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0) {
printk(KERN_ERR
"firmware_sample_driver: Firmware not available\n");
return;
@@ -56,8 +55,7 @@ static void sample_probe_specific(void)
printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
- if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0)
- {
+ if (request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0) {
printk(KERN_ERR
"firmware_sample_driver: Firmware load failed\n");
return;
@@ -70,7 +68,7 @@ static void sample_probe_specific(void)
}
static void sample_probe_async_cont(const struct firmware *fw, void *context)
{
- if(!fw){
+ if (!fw) {
printk(KERN_ERR
"firmware_sample_driver: firmware load failed\n");
return;
@@ -88,9 +86,8 @@ static void sample_probe_async(void)
"sample_driver_fw", &ghost_device,
"my device pointer",
sample_probe_async_cont);
- if(error){
- printk(KERN_ERR
- "firmware_sample_driver:"
+ if (error) {
+ printk(KERN_ERR "firmware_sample_driver:"
" request_firmware_nowait failed\n");
}
}
@@ -105,6 +102,7 @@ static int sample_init(void)
sample_probe_async();
return 0;
}
+
static void __exit sample_exit(void)
{
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: firmware_sample_driver.c: fix coding style
2008-04-01 10:55 firmware_sample_driver.c: fix coding style Pavel Machek
@ 2008-04-21 21:49 ` Jesper Juhl
0 siblings, 0 replies; 2+ messages in thread
From: Jesper Juhl @ 2008-04-21 21:49 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Andrew Morton, Trivial patch monkey
On Tue, 1 Apr 2008, Pavel Machek wrote:
> Fix coding style in firmware_sample_driver...
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
I've added this patch to the trivial tree.
Thanks Pavel.
/Jesper Juhl
> diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c
> index 6865cbe..600cdd9 100644
> --- a/Documentation/firmware_class/firmware_sample_driver.c
> +++ b/Documentation/firmware_class/firmware_sample_driver.c
> @@ -34,8 +34,7 @@ static void sample_probe_default(void)
> const struct firmware *fw_entry;
> printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>
> - if(request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0)
> - {
> + if (request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0) {
> printk(KERN_ERR
> "firmware_sample_driver: Firmware not available\n");
> return;
> @@ -56,8 +55,7 @@ static void sample_probe_specific(void)
>
> printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>
> - if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0)
> - {
> + if (request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0) {
> printk(KERN_ERR
> "firmware_sample_driver: Firmware load failed\n");
> return;
> @@ -70,7 +68,7 @@ static void sample_probe_specific(void)
> }
> static void sample_probe_async_cont(const struct firmware *fw, void *context)
> {
> - if(!fw){
> + if (!fw) {
> printk(KERN_ERR
> "firmware_sample_driver: firmware load failed\n");
> return;
> @@ -88,9 +86,8 @@ static void sample_probe_async(void)
> "sample_driver_fw", &ghost_device,
> "my device pointer",
> sample_probe_async_cont);
> - if(error){
> - printk(KERN_ERR
> - "firmware_sample_driver:"
> + if (error) {
> + printk(KERN_ERR "firmware_sample_driver:"
> " request_firmware_nowait failed\n");
> }
> }
> @@ -105,6 +102,7 @@ static int sample_init(void)
> sample_probe_async();
> return 0;
> }
> +
> static void __exit sample_exit(void)
> {
> }
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-21 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-01 10:55 firmware_sample_driver.c: fix coding style Pavel Machek
2008-04-21 21:49 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).