LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC PATCH 2/3] Remove XFS specific ioctl interfaces for freeze feature
@ 2008-04-01 12:18 Takashi Sato
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Sato @ 2008-04-01 12:18 UTC (permalink / raw)
  To: David Chinner; +Cc: linux-fsdevel, linux-ext4, xfs, dm-devel, linux-kernel

It removes XFS specific ioctl interfaces and request codes
for freeze feature.
This patch has been supplied by David Chinner.

Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Takashi Sato <t-sato@yk.jp.nec.com>
---
 linux-2.6/xfs_ioctl.c   |   15 ---------------
 linux-2.6/xfs_ioctl32.c |    2 --
 xfs_fs.h                |    4 ++--
 3 files changed, 2 insertions(+), 19 deletions(-)

diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-rc7-freeze/fs/xfs/linux-2.6/xfs_ioctl.c linux-2.6.25-rc7
-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
--- linux-2.6.25-rc7-freeze/fs/xfs/linux-2.6/xfs_ioctl.c	2008-04-01 13:22:43.000000000 +0900
+++ linux-2.6.25-rc7-xfs/fs/xfs/linux-2.6/xfs_ioctl.c	2008-04-01 14:34:21.000000000 +0900
@@ -906,21 +906,6 @@ xfs_ioctl(
 		return -error;
 	}
 
-	case XFS_IOC_FREEZE:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-
-		if (inode->i_sb->s_frozen == SB_UNFROZEN)
-			freeze_bdev(inode->i_sb->s_bdev);
-		return 0;
-
-	case XFS_IOC_THAW:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-		if (inode->i_sb->s_frozen != SB_UNFROZEN)
-			thaw_bdev(inode->i_sb->s_bdev, inode->i_sb);
-		return 0;
-
 	case XFS_IOC_GOINGDOWN: {
 		__uint32_t in;
 
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-rc7-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c linux-2.6.25-r
c7-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c
--- linux-2.6.25-rc7-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-04-01 13:22:43.000000000 +0900
+++ linux-2.6.25-rc7-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-04-01 14:31:59.000000000 +0900
@@ -398,8 +398,6 @@ xfs_compat_ioctl(
 	case XFS_IOC_FSGROWFSDATA:
 	case XFS_IOC_FSGROWFSLOG:
 	case XFS_IOC_FSGROWFSRT:
-	case XFS_IOC_FREEZE:
-	case XFS_IOC_THAW:
 	case XFS_IOC_GOINGDOWN:
 	case XFS_IOC_ERROR_INJECTION:
 	case XFS_IOC_ERROR_CLEARALL:
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-rc7-freeze/fs/xfs/xfs_fs.h linux-2.6.25-rc7-xfs/fs/xfs/x
fs_fs.h
--- linux-2.6.25-rc7-freeze/fs/xfs/xfs_fs.h	2008-04-01 13:22:48.000000000 +0900
+++ linux-2.6.25-rc7-xfs/fs/xfs/xfs_fs.h	2008-04-01 14:31:59.000000000 +0900
@@ -473,8 +473,8 @@ typedef struct xfs_handle {
 #define XFS_IOC_ERROR_INJECTION	     _IOW ('X', 116, struct xfs_error_injection)
 #define XFS_IOC_ERROR_CLEARALL	     _IOW ('X', 117, struct xfs_error_injection)
 /*	XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118	 */
-#define XFS_IOC_FREEZE		     _IOWR('X', 119, int)
-#define XFS_IOC_THAW		     _IOWR('X', 120, int)
+/*	XFS_IOC_FREEZE		  -- FIFREEZE   119	 */
+/*	XFS_IOC_THAW		  -- FITHAW     120	 */
 #define XFS_IOC_FSSETDM_BY_HANDLE    _IOW ('X', 121, struct xfs_fsop_setdm_handlereq)
 #define XFS_IOC_ATTRLIST_BY_HANDLE   _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq)
 #define XFS_IOC_ATTRMULTI_BY_HANDLE  _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 2/3] Remove XFS specific ioctl interfaces for freeze feature
@ 2008-05-22  8:50 Takashi Sato
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Sato @ 2008-05-22  8:50 UTC (permalink / raw)
  To: linux-ext4, xfs, dm-devel, linux-fsdevel; +Cc: linux-kernel

It removes XFS specific ioctl interfaces and request codes
for freeze feature.
This patch has been supplied by David Chinner.

Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Takashi Sato <t-sato@yk.jp.nec.com>
---
 linux-2.6/xfs_ioctl.c   |   15 ---------------
 linux-2.6/xfs_ioctl32.c |    2 --
 xfs_fs.h                |    4 ++--
 3 files changed, 2 insertions(+), 19 deletions(-)

diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc3-freeze/fs/xfs/linux-2.6/xfs_ioctl.c linux-2.6.26-rc3
-xfs/fs/xfs/linux-2.6/xfs_ioctl.c
--- linux-2.6.26-rc3-freeze/fs/xfs/linux-2.6/xfs_ioctl.c	2008-05-19 21:02:30.000000000 +0900
+++ linux-2.6.26-rc3-xfs/fs/xfs/linux-2.6/xfs_ioctl.c	2008-05-19 21:04:22.000000000 +0900
@@ -1233,21 +1233,6 @@ xfs_ioctl(
 		return -error;
 	}
 
-	case XFS_IOC_FREEZE:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-
-		if (inode->i_sb->s_frozen == SB_UNFROZEN)
-			freeze_bdev(inode->i_sb->s_bdev);
-		return 0;
-
-	case XFS_IOC_THAW:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-		if (inode->i_sb->s_frozen != SB_UNFROZEN)
-			thaw_bdev(inode->i_sb->s_bdev, inode->i_sb);
-		return 0;
-
 	case XFS_IOC_GOINGDOWN: {
 		__uint32_t in;
 
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc3-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c linux-2.6.26-r
c3-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c
--- linux-2.6.26-rc3-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-05-19 21:02:30.000000000 +0900
+++ linux-2.6.26-rc3-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-05-19 21:04:22.000000000 +0900
@@ -398,8 +398,6 @@ xfs_compat_ioctl(
 	case XFS_IOC_FSGROWFSDATA:
 	case XFS_IOC_FSGROWFSLOG:
 	case XFS_IOC_FSGROWFSRT:
-	case XFS_IOC_FREEZE:
-	case XFS_IOC_THAW:
 	case XFS_IOC_GOINGDOWN:
 	case XFS_IOC_ERROR_INJECTION:
 	case XFS_IOC_ERROR_CLEARALL:
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc3-freeze/fs/xfs/xfs_fs.h linux-2.6.26-rc3-xfs/fs/xfs/x
fs_fs.h
--- linux-2.6.26-rc3-freeze/fs/xfs/xfs_fs.h	2008-05-19 21:02:30.000000000 +0900
+++ linux-2.6.26-rc3-xfs/fs/xfs/xfs_fs.h	2008-05-19 21:04:22.000000000 +0900
@@ -473,8 +473,8 @@ typedef struct xfs_handle {
 #define XFS_IOC_ERROR_INJECTION	     _IOW ('X', 116, struct xfs_error_injection)
 #define XFS_IOC_ERROR_CLEARALL	     _IOW ('X', 117, struct xfs_error_injection)
 /*	XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118	 */
-#define XFS_IOC_FREEZE		     _IOWR('X', 119, int)
-#define XFS_IOC_THAW		     _IOWR('X', 120, int)
+/*	XFS_IOC_FREEZE		  -- FIFREEZE   119	 */
+/*	XFS_IOC_THAW		  -- FITHAW     120	 */
 #define XFS_IOC_FSSETDM_BY_HANDLE    _IOW ('X', 121, struct xfs_fsop_setdm_handlereq)
 #define XFS_IOC_ATTRLIST_BY_HANDLE   _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq)
 #define XFS_IOC_ATTRMULTI_BY_HANDLE  _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 2/3] Remove XFS specific ioctl interfaces for freeze feature
@ 2008-05-14  8:07 Takashi Sato
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Sato @ 2008-05-14  8:07 UTC (permalink / raw)
  To: linux-ext4, xfs, dm-devel, linux-fsdevel; +Cc: linux-kernel

It removes XFS specific ioctl interfaces and request codes
for freeze feature.
This patch has been supplied by David Chinner.

Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Takashi Sato <t-sato@yk.jp.nec.com>
---
 linux-2.6/xfs_ioctl.c   |   15 ---------------
 linux-2.6/xfs_ioctl32.c |    2 --
 xfs_fs.h                |    4 ++--
 3 files changed, 2 insertions(+), 19 deletions(-)

diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc2-bit/fs/xfs/linux-2.6/xfs_ioctl.c linux-2.6.26-rc2-xf
s/fs/xfs/linux-2.6/xfs_ioctl.c
--- linux-2.6.26-rc2-bit/fs/xfs/linux-2.6/xfs_ioctl.c	2008-05-12 11:15:10.000000000 +0900
+++ linux-2.6.26-rc2-xfs/fs/xfs/linux-2.6/xfs_ioctl.c	2008-05-12 11:25:50.000000000 +0900
@@ -1233,21 +1233,6 @@ xfs_ioctl(
 		return -error;
 	}
 
-	case XFS_IOC_FREEZE:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-
-		if (inode->i_sb->s_frozen == SB_UNFROZEN)
-			freeze_bdev(inode->i_sb->s_bdev);
-		return 0;
-
-	case XFS_IOC_THAW:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-		if (inode->i_sb->s_frozen != SB_UNFROZEN)
-			thaw_bdev(inode->i_sb->s_bdev, inode->i_sb);
-		return 0;
-
 	case XFS_IOC_GOINGDOWN: {
 		__uint32_t in;
 
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc2-bit/fs/xfs/linux-2.6/xfs_ioctl32.c linux-2.6.26-rc2-
xfs/fs/xfs/linux-2.6/xfs_ioctl32.c
--- linux-2.6.26-rc2-bit/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-05-12 11:15:10.000000000 +0900
+++ linux-2.6.26-rc2-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-05-12 11:25:50.000000000 +0900
@@ -398,8 +398,6 @@ xfs_compat_ioctl(
 	case XFS_IOC_FSGROWFSDATA:
 	case XFS_IOC_FSGROWFSLOG:
 	case XFS_IOC_FSGROWFSRT:
-	case XFS_IOC_FREEZE:
-	case XFS_IOC_THAW:
 	case XFS_IOC_GOINGDOWN:
 	case XFS_IOC_ERROR_INJECTION:
 	case XFS_IOC_ERROR_CLEARALL:
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.26-rc2-bit/fs/xfs/xfs_fs.h linux-2.6.26-rc2-xfs/fs/xfs/xfs_
fs.h
--- linux-2.6.26-rc2-bit/fs/xfs/xfs_fs.h	2008-05-12 11:15:11.000000000 +0900
+++ linux-2.6.26-rc2-xfs/fs/xfs/xfs_fs.h	2008-05-12 11:25:50.000000000 +0900
@@ -473,8 +473,8 @@ typedef struct xfs_handle {
 #define XFS_IOC_ERROR_INJECTION	     _IOW ('X', 116, struct xfs_error_injection)
 #define XFS_IOC_ERROR_CLEARALL	     _IOW ('X', 117, struct xfs_error_injection)
 /*	XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118	 */
-#define XFS_IOC_FREEZE		     _IOWR('X', 119, int)
-#define XFS_IOC_THAW		     _IOWR('X', 120, int)
+/*	XFS_IOC_FREEZE		  -- FIFREEZE   119	 */
+/*	XFS_IOC_THAW		  -- FITHAW     120	 */
 #define XFS_IOC_FSSETDM_BY_HANDLE    _IOW ('X', 121, struct xfs_fsop_setdm_handlereq)
 #define XFS_IOC_ATTRLIST_BY_HANDLE   _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq)
 #define XFS_IOC_ATTRMULTI_BY_HANDLE  _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC PATCH 2/3] Remove XFS specific ioctl interfaces for freeze feature
@ 2008-04-28 10:31 Takashi Sato
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Sato @ 2008-04-28 10:31 UTC (permalink / raw)
  To: linux-fsdevel, linux-ext4, xfs, dm-devel; +Cc: linux-kernel

It removes XFS specific ioctl interfaces and request codes
for freeze feature.
This patch has been supplied by David Chinner.

Signed-off-by: Dave Chinner <dgc@sgi.com>
Signed-off-by: Takashi Sato <t-sato@yk.jp.nec.com>
---
 linux-2.6/xfs_ioctl.c   |   15 ---------------
 linux-2.6/xfs_ioctl32.c |    2 --
 xfs_fs.h                |    4 ++--
 3 files changed, 2 insertions(+), 19 deletions(-)

diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-freeze/fs/xfs/linux-2.6/xfs_ioctl.c linux-2.6.25-xfs/fs/
xfs/linux-2.6/xfs_ioctl.c
--- linux-2.6.25-freeze/fs/xfs/linux-2.6/xfs_ioctl.c	2008-04-24 20:42:20.000000000 +0900
+++ linux-2.6.25-xfs/fs/xfs/linux-2.6/xfs_ioctl.c	2008-04-24 20:44:48.000000000 +0900
@@ -906,21 +906,6 @@ xfs_ioctl(
 		return -error;
 	}
 
-	case XFS_IOC_FREEZE:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-
-		if (inode->i_sb->s_frozen == SB_UNFROZEN)
-			freeze_bdev(inode->i_sb->s_bdev);
-		return 0;
-
-	case XFS_IOC_THAW:
-		if (!capable(CAP_SYS_ADMIN))
-			return -EPERM;
-		if (inode->i_sb->s_frozen != SB_UNFROZEN)
-			thaw_bdev(inode->i_sb->s_bdev, inode->i_sb);
-		return 0;
-
 	case XFS_IOC_GOINGDOWN: {
 		__uint32_t in;
 
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c linux-2.6.25-xfs/f
s/xfs/linux-2.6/xfs_ioctl32.c
--- linux-2.6.25-freeze/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-04-24 20:42:20.000000000 +0900
+++ linux-2.6.25-xfs/fs/xfs/linux-2.6/xfs_ioctl32.c	2008-04-24 20:44:48.000000000 +0900
@@ -398,8 +398,6 @@ xfs_compat_ioctl(
 	case XFS_IOC_FSGROWFSDATA:
 	case XFS_IOC_FSGROWFSLOG:
 	case XFS_IOC_FSGROWFSRT:
-	case XFS_IOC_FREEZE:
-	case XFS_IOC_THAW:
 	case XFS_IOC_GOINGDOWN:
 	case XFS_IOC_ERROR_INJECTION:
 	case XFS_IOC_ERROR_CLEARALL:
diff -uprN -X /home/sho/pub/MC/freeze-set/dontdiff linux-2.6.25-freeze/fs/xfs/xfs_fs.h linux-2.6.25-xfs/fs/xfs/xfs_fs.h
--- linux-2.6.25-freeze/fs/xfs/xfs_fs.h	2008-04-24 20:42:20.000000000 +0900
+++ linux-2.6.25-xfs/fs/xfs/xfs_fs.h	2008-04-24 20:44:48.000000000 +0900
@@ -473,8 +473,8 @@ typedef struct xfs_handle {
 #define XFS_IOC_ERROR_INJECTION	     _IOW ('X', 116, struct xfs_error_injection)
 #define XFS_IOC_ERROR_CLEARALL	     _IOW ('X', 117, struct xfs_error_injection)
 /*	XFS_IOC_ATTRCTL_BY_HANDLE -- deprecated 118	 */
-#define XFS_IOC_FREEZE		     _IOWR('X', 119, int)
-#define XFS_IOC_THAW		     _IOWR('X', 120, int)
+/*	XFS_IOC_FREEZE		  -- FIFREEZE   119	 */
+/*	XFS_IOC_THAW		  -- FITHAW     120	 */
 #define XFS_IOC_FSSETDM_BY_HANDLE    _IOW ('X', 121, struct xfs_fsop_setdm_handlereq)
 #define XFS_IOC_ATTRLIST_BY_HANDLE   _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq)
 #define XFS_IOC_ATTRMULTI_BY_HANDLE  _IOW ('X', 123, struct xfs_fsop_attrmulti_handlereq)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-05-22  8:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-01 12:18 [RFC PATCH 2/3] Remove XFS specific ioctl interfaces for freeze feature Takashi Sato
2008-04-28 10:31 Takashi Sato
2008-05-14  8:07 Takashi Sato
2008-05-22  8:50 Takashi Sato

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).