LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: benh@kernel.crashing.org
Cc: Nigel Cunningham <ncunningham@crca.org.au>,
	pm list <linux-pm@lists.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>, Greg KH <greg@kroah.com>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	David Brownell <david-b@pacbell.net>, Pavel Machek <pavel@ucw.cz>,
	Oliver Neukum <oliver@neukum.org>
Subject: Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)
Date: Tue, 1 Apr 2008 22:16:07 +0200	[thread overview]
Message-ID: <200804012216.08318.rjw@sisk.pl> (raw)
In-Reply-To: <1207038460.10388.214.camel@pasglop>

On Tuesday, 1 of April 2008, Benjamin Herrenschmidt wrote:
> 
> On Tue, 2008-04-01 at 19:15 +1100, Nigel Cunningham wrote:
> > > + *   However, drivers may NOT assume anything about the availability of the
> > > + *   user space at that time and it is not correct to request firmware from
> > > + *   within @prepare() (it's too late to do that).
> > 
> > That doesn't sound good. It would be good to be able to get drivers to
> > request firmware early in the process.
> 
> Agreed. Prepare() should still allow request_firmware and full userspace
> communication / helper usage.

This documents the current state which is that we have the freezer and we have
drivers that rely on it.

I can remove the comment, but then someone will invent ->prepare() relying
on the availability of the user space at this point and that won't work.

Thanks,
Rafael

  parent reply	other threads:[~2008-04-01 20:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29 22:17 [RFC][PATCH 0/3] PM: Rework suspend and hibernation code for devices (rev. 3) Rafael J. Wysocki
2008-03-29 22:20 ` [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 5) Rafael J. Wysocki
2008-03-30  2:54   ` Rafael J. Wysocki
2008-03-31 21:29     ` [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6) Rafael J. Wysocki
2008-04-01  8:15       ` Nigel Cunningham
2008-04-01  8:27         ` Benjamin Herrenschmidt
2008-04-01 14:31           ` Alan Stern
2008-04-01 19:34             ` Nigel Cunningham
2008-04-01 20:16           ` Rafael J. Wysocki [this message]
2008-04-01 20:12         ` Rafael J. Wysocki
2008-04-01 20:56           ` Alan Stern
2008-04-01 21:38             ` Nigel Cunningham
2008-04-01 21:59               ` Rafael J. Wysocki
2008-04-01 21:50             ` Rafael J. Wysocki
2008-04-02 14:11               ` Alan Stern
2008-04-02 14:22                 ` Oliver Neukum
2008-04-02 15:13                   ` Alan Stern
2008-04-02 15:28                     ` Oliver Neukum
2008-04-02 16:42                       ` Alan Stern
2008-04-02 20:11                         ` Oliver Neukum
2008-04-02 20:28                           ` Alan Stern
2008-04-01 21:35           ` Nigel Cunningham
2008-04-01 21:57             ` Rafael J. Wysocki
2008-04-01 22:32               ` Nigel Cunningham
2008-04-01 23:00                 ` Rafael J. Wysocki
2008-04-01  8:37       ` Pavel Machek
2008-04-01 20:23         ` Rafael J. Wysocki
2008-03-29 22:22 ` [RFC][PATCH 2/3] PM: New suspend and hibernation callbacks for platform bus type (rev. 3) Rafael J. Wysocki
2008-03-30  2:56   ` Rafael J. Wysocki
2008-03-29 22:23 ` [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804012216.08318.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=astarikovskiy@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=ncunningham@crca.org.au \
    --cc=oliver@neukum.org \
    --cc=pavel@ucw.cz \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).