LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <email@example.com>
To: Nigel Cunningham <firstname.lastname@example.org>
Cc: Alan Stern <email@example.com>,
pm list <firstname.lastname@example.org>,
ACPI Devel Maling List <email@example.com>,
Greg KH <firstname.lastname@example.org>, Len Brown <email@example.com>,
Alexey Starikovskiy <firstname.lastname@example.org>,
David Brownell <email@example.com>, Pavel Machek <firstname.lastname@example.org>,
Benjamin Herrenschmidt <email@example.com>,
Oliver Neukum <firstname.lastname@example.org>
Subject: Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)
Date: Tue, 1 Apr 2008 23:59:52 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
On Tuesday, 1 of April 2008, Nigel Cunningham wrote:
> On Tue, 2008-04-01 at 16:56 -0400, Alan Stern wrote:
> > On Tue, 1 Apr 2008, Rafael J. Wysocki wrote:
> > > > Does ..._ext_... mean extended? (external?) If 'extended' (or if not),
> > > > does that imply that they're mutually exclusive alternatives for drivers
> > > > to use?
> > >
> > > 'ext' means 'extended'. The idea is that the 'extended' version will be used
> > > by bus types / driver types that don't need to implement the _noirq callbacks.
> > Something's wrong here. This seems to say that the "extended" version
> > has _fewer_ method pointers -- in which case it should be called
> > "restricted" instead.
This was a mistake explained in another message. The "don't" should not be
present in the above sentence.
> > > > So drivers can never validly fail to resume. That sounds fair enough. If
> > > > the hardware has gone away while in lower power mode (USB, say), should
> > > > the driver then just printk an error and return success?
> > >
> > > I think so.
> > >
> > > IMO, an error code returned by a driver's ->resume() should mean "the device
> > > hasn't resumed and is presumably dead". Otherwise, ->resume() should return
> > > success.
> > If the device is gone, it doesn't much matter what resume() returns.
> What if the same driver is handling multiple instances and only some of
> them fail to resume?
->resume() will be called separately for each of them.
next prev parent reply other threads:[~2008-04-01 22:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 22:17 [RFC][PATCH 0/3] PM: Rework suspend and hibernation code for devices (rev. 3) Rafael J. Wysocki
2008-03-29 22:20 ` [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 5) Rafael J. Wysocki
2008-03-30 2:54 ` Rafael J. Wysocki
2008-03-31 21:29 ` [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6) Rafael J. Wysocki
2008-04-01 8:15 ` Nigel Cunningham
2008-04-01 8:27 ` Benjamin Herrenschmidt
2008-04-01 14:31 ` Alan Stern
2008-04-01 19:34 ` Nigel Cunningham
2008-04-01 20:16 ` Rafael J. Wysocki
2008-04-01 20:12 ` Rafael J. Wysocki
2008-04-01 20:56 ` Alan Stern
2008-04-01 21:38 ` Nigel Cunningham
2008-04-01 21:59 ` Rafael J. Wysocki [this message]
2008-04-01 21:50 ` Rafael J. Wysocki
2008-04-02 14:11 ` Alan Stern
2008-04-02 14:22 ` Oliver Neukum
2008-04-02 15:13 ` Alan Stern
2008-04-02 15:28 ` Oliver Neukum
2008-04-02 16:42 ` Alan Stern
2008-04-02 20:11 ` Oliver Neukum
2008-04-02 20:28 ` Alan Stern
2008-04-01 21:35 ` Nigel Cunningham
2008-04-01 21:57 ` Rafael J. Wysocki
2008-04-01 22:32 ` Nigel Cunningham
2008-04-01 23:00 ` Rafael J. Wysocki
2008-04-01 8:37 ` Pavel Machek
2008-04-01 20:23 ` Rafael J. Wysocki
2008-03-29 22:22 ` [RFC][PATCH 2/3] PM: New suspend and hibernation callbacks for platform bus type (rev. 3) Rafael J. Wysocki
2008-03-30 2:56 ` Rafael J. Wysocki
2008-03-29 22:23 ` [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI " Rafael J. Wysocki
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).