Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Dmitry Torokhov]

Hi Yanko,

On Wed, Apr 02, 2008 at 02:17:31AM +0300, Yanko Kaneti wrote:
> On Tue, 2008-03-18 at 11:54 -0400, Dmitry Torokhov wrote:
> > On Mon, Mar 17, 2008 at 08:58:43PM +0200, Yanko Kaneti wrote:
> > > On Mon, 2008-03-17 at 14:55 -0400, Dmitry Torokhov wrote:
> > > > On Mon, Mar 17, 2008 at 07:33:49PM +0200, Yanko Kaneti wrote:
> > > > >
> > > > > My PS/2 mouse stops being detected between kernels 2.6.24.3-12.fc8 and
> > > > > 2.6.25-0.121.rc5.git4.fc9 (which I believe do not carry any patches in
> > > > > that area). Its an ASUS P5E-VM DO motherboard , bios revision 0506. The
> > > > > PS/2 keyboard still works.
> > > > > 
> > > > > Attached are both dmesg logs with i8042.debug=1, dmidecode, lspci -vvnn
> > > > > Tried i8042.noloop and both the mouse and keyboard stop working.
> > > > > 
> > > > 
> > > > Could you please send me dmesg from booting with i8042.noloop. I would
> > > > expect this option to help in your case so I am curious what went wrong.
> > > 
> > > Attached
> > > 
> > 
> > Hmm, it looks the kernel does the right thing in case of i8042.noloop,
> > except that it does not work :(. Kernel triest to query the mouse but
> > it does not respond.
> > 
> > Can you try taking contents of drivers/input/serio from 2.6.25 and
> > copy it in .24? It will most likely compile... If that works I'm
> > afraid I will ahve to ask you to do git biscect to find the offending
> > commit.
> 
> Hey again,
> 
> I finally did the bisecting. It found the cuplrit to be
> 
> commit e3f37a54f690d3e64995ea7ecea08c5ab3070faf
> Author: Balaji Rao <balajirrao@gmail.com>
> Date:   Wed Jan 30 13:30:03 2008 +0100
> 
>     x86: assign IRQs to HPET timers
>     
> 
> I tried reverting the change on the latest git with the attached patch
> and my mouse and keyboard appear to be detected and working fine now.
> The patch had to be stiched by hand and due to my lack of understanding
> of the code might be breaking random other stuff.
> 
> FWIW the bios on this board has no knobs for HPET that I could find.
> 
> What gives?
> 

Hmm, this is wierd and really outsize of my knowledge... Lets try copying
Ingo, Thomas and Balaji, maybe they can help us out here.

Btw, what is in your /proc/interrupts?

-- 
Dmitry

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Balaji Rao]

On Wednesday 02 April 2008 08:29:00 pm Dmitry Torokhov wrote:
> Hi Yanko,
> 
> On Wed, Apr 02, 2008 at 02:17:31AM +0300, Yanko Kaneti wrote:
> > On Tue, 2008-03-18 at 11:54 -0400, Dmitry Torokhov wrote:
> > > On Mon, Mar 17, 2008 at 08:58:43PM +0200, Yanko Kaneti wrote:
> > > > On Mon, 2008-03-17 at 14:55 -0400, Dmitry Torokhov wrote:
> > > > > On Mon, Mar 17, 2008 at 07:33:49PM +0200, Yanko Kaneti wrote:
> > > > > >
> > > > > > My PS/2 mouse stops being detected between kernels 2.6.24.3-12.fc8 
and
> > > > > > 2.6.25-0.121.rc5.git4.fc9 (which I believe do not carry any 
patches in
> > > > > > that area). Its an ASUS P5E-VM DO motherboard , bios revision 
0506. The
> > > > > > PS/2 keyboard still works.
> > > > > > 
> > > > > > Attached are both dmesg logs with i8042.debug=1, dmidecode, 
lspci -vvnn
> > > > > > Tried i8042.noloop and both the mouse and keyboard stop working.
> > > > > > 
> > > > > 
> > > > > Could you please send me dmesg from booting with i8042.noloop. I 
would
> > > > > expect this option to help in your case so I am curious what went 
wrong.
> > > > 
> > > > Attached
> > > > 
> > > 
> > > Hmm, it looks the kernel does the right thing in case of i8042.noloop,
> > > except that it does not work :(. Kernel triest to query the mouse but
> > > it does not respond.
> > > 
> > > Can you try taking contents of drivers/input/serio from 2.6.25 and
> > > copy it in .24? It will most likely compile... If that works I'm
> > > afraid I will ahve to ask you to do git biscect to find the offending
> > > commit.
> > 
> > Hey again,
> > 
> > I finally did the bisecting. It found the cuplrit to be
> > 
> > commit e3f37a54f690d3e64995ea7ecea08c5ab3070faf
> > Author: Balaji Rao <balajirrao@gmail.com>
> > Date:   Wed Jan 30 13:30:03 2008 +0100
> > 
> >     x86: assign IRQs to HPET timers
> >     
> > 
> > I tried reverting the change on the latest git with the attached patch
> > and my mouse and keyboard appear to be detected and working fine now.
> > The patch had to be stiched by hand and due to my lack of understanding
> > of the code might be breaking random other stuff.
> > 
> > FWIW the bios on this board has no knobs for HPET that I could find.
> > 
> > What gives?
> > 
> 
> Hmm, this is wierd and really outsize of my knowledge... Lets try copying
> Ingo, Thomas and Balaji, maybe they can help us out here.
> 
> Btw, what is in your /proc/interrupts?
> 
Hi,

Coincidentally even I hit upon this bug a couple of days ago after enabling 
HPET in my BIOS. A quick check told me that IRQ 12 which the patch assigns to 
the HPET device is used by the PS/2 mouse as well. This makes the mouse 
inactive.

I am working on this.. I am not sure if the PS/2 code is misbehaving though..

-- 
regards,
Balaji Rao
Dept. of Mechanical Engineering,
National Institute of Technology Karnataka, India

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Dmitry Torokhov]

Hi Blaji,

On Wed, Apr 02, 2008 at 08:38:33PM +0530, Balaji Rao wrote:
> 
> Coincidentally even I hit upon this bug a couple of days ago after enabling 
> HPET in my BIOS. A quick check told me that IRQ 12 which the patch assigns to 
> the HPET device is used by the PS/2 mouse as well. This makes the mouse 
> inactive.
> 
> I am working on this.. I am not sure if the PS/2 code is misbehaving though..
>

Normally IRQ12 can not be shared on X86 if PS/2 mouse is present.
If PCI side tries to grab the IRQ then ISA (legacy) side will never
see its interrupts coming.

-- 
Dmitry

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Balaji Rao]

On Wednesday 02 April 2008 09:03:28 pm Dmitry Torokhov wrote:
> Hi Blaji,
> 
> On Wed, Apr 02, 2008 at 08:38:33PM +0530, Balaji Rao wrote:
> > 
> > Coincidentally even I hit upon this bug a couple of days ago after enabling 
> > HPET in my BIOS. A quick check told me that IRQ 12 which the patch assigns to 
> > the HPET device is used by the PS/2 mouse as well. This makes the mouse 
> > inactive.
> > 
> > I am working on this.. I am not sure if the PS/2 code is misbehaving though..
> >
> 
> Normally IRQ12 can not be shared on X86 if PS/2 mouse is present.
> If PCI side tries to grab the IRQ then ISA (legacy) side will never
> see its interrupts coming.
> 
OK. So, I need to specifically check for IRQ12 being assigned and avoid it ?

-- 
regards,
balaji rao
Dept. of Mechanical Engineering,
National Institute of Technology Karnataka, India

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Dmitry Torokhov]

On Wed, Apr 02, 2008 at 11:00:13PM +0530, Balaji Rao wrote:
> On Wednesday 02 April 2008 09:03:28 pm Dmitry Torokhov wrote:
> > Hi Blaji,
> > 
> > On Wed, Apr 02, 2008 at 08:38:33PM +0530, Balaji Rao wrote:
> > > 
> > > Coincidentally even I hit upon this bug a couple of days ago after enabling 
> > > HPET in my BIOS. A quick check told me that IRQ 12 which the patch assigns to 
> > > the HPET device is used by the PS/2 mouse as well. This makes the mouse 
> > > inactive.
> > > 
> > > I am working on this.. I am not sure if the PS/2 code is misbehaving though..
> > >
> > 
> > Normally IRQ12 can not be shared on X86 if PS/2 mouse is present.
> > If PCI side tries to grab the IRQ then ISA (legacy) side will never
> > see its interrupts coming.
> > 
> OK. So, I need to specifically check for IRQ12 being assigned and avoid it ?
> 

Yeah.. I think there are other legacy IRQs that should be avoided as well.
I am pretty sure Ingo would have a better idea which they are.

-- 
Dmitry

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Thomas Gleixner]

On Fri, 4 Apr 2008, Balaji Rao wrote:

> On Friday 04 April 2008 07:03:50 pm Thomas Gleixner wrote:
> > On Fri, 4 Apr 2008, Rafael J. Wysocki wrote:
> > > The following report is on the current list of known regressions
> > > from 2.6.24.  Please verify if the issue is still present in the
> > > mainline.
> > 
> > Yes, it is. The revert of the patch which caused that is queued for
> > todays push to Linus.
> > 
> > Thanks,
> > 
> > 	tglx
> > 
> > > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10382
> > > Subject		: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working
> > > Submitter	: Yanko Kaneti <yaneti@declera.com>
> > > Date		: 2008-04-02 10:59 (2 days old)
> > > References	: http://lkml.org/lkml/2008/4/2/210
> > > Handled-By	: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > 		  Balaji Rao <balajirrao@gmail.com>
> > > 
> > > 
> > 
> Hi tglx,
> 
> I think the following commit should also be reverted. 
> 
> commit 37a47db8d7f0f38dac5acf5a13abbc8f401707fa
> Author: Balaji Rao <balajirrao@gmail.com>
> Date:   Wed Jan 30 13:30:03 2008 +0100
> 
>     x86: assign IRQs to HPET timers, fix

Yup, I have both.

Anyway, thanks for the reminder 

	tglx

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Balaji Rao]

On Friday 04 April 2008 07:03:50 pm Thomas Gleixner wrote:
> On Fri, 4 Apr 2008, Rafael J. Wysocki wrote:
> > The following report is on the current list of known regressions
> > from 2.6.24.  Please verify if the issue is still present in the
> > mainline.
> 
> Yes, it is. The revert of the patch which caused that is queued for
> todays push to Linus.
> 
> Thanks,
> 
> 	tglx
> 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10382
> > Subject		: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working
> > Submitter	: Yanko Kaneti <yaneti@declera.com>
> > Date		: 2008-04-02 10:59 (2 days old)
> > References	: http://lkml.org/lkml/2008/4/2/210
> > Handled-By	: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 		  Balaji Rao <balajirrao@gmail.com>
> > 
> > 
> 
Hi tglx,

I think the following commit should also be reverted. 

commit 37a47db8d7f0f38dac5acf5a13abbc8f401707fa
Author: Balaji Rao <balajirrao@gmail.com>
Date:   Wed Jan 30 13:30:03 2008 +0100

    x86: assign IRQs to HPET timers, fix

-- 
regards,
Balaji Rao

Re: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Thomas Gleixner]

On Fri, 4 Apr 2008, Rafael J. Wysocki wrote:
> The following report is on the current list of known regressions
> from 2.6.24.  Please verify if the issue is still present in the
> mainline.

Yes, it is. The revert of the patch which caused that is queued for
todays push to Linus.

Thanks,

	tglx

> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10382
> Subject		: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working
> Submitter	: Yanko Kaneti <yaneti@declera.com>
> Date		: 2008-04-02 10:59 (2 days old)
> References	: http://lkml.org/lkml/2008/4/2/210
> Handled-By	: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 		  Balaji Rao <balajirrao@gmail.com>
> 
> 

2.6.25-rc5.git4 regression PS/2 mouse not detected/working

[Rafael J. Wysocki]

The following report is on the current list of known regressions
from 2.6.24.  Please verify if the issue is still present in the
mainline.


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10382
Subject		: 2.6.25-rc5.git4 regression PS/2 mouse not detected/working
Submitter	: Yanko Kaneti <yaneti@declera.com>
Date		: 2008-04-02 10:59 (2 days old)
References	: http://lkml.org/lkml/2008/4/2/210
Handled-By	: Dmitry Torokhov <dmitry.torokhov@gmail.com>
		  Balaji Rao <balajirrao@gmail.com>