LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Michael Kerrisk <mtk.manpages@googlemail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, mtk.manpages@gmail.com
Subject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen
Date: Thu, 24 Apr 2008 01:16:56 +0100	[thread overview]
Message-ID: <20080424001656.GM4825@implementation> (raw)
In-Reply-To: <4808D1C5.8050304@gmail.com>

Michael Kerrisk, le Fri 18 Apr 2008 18:52:21 +0200, a écrit :
> >>  +is
> >>  +.IR sizeof(sa_family_t) ,
> 
> Why did you write sa_family_t here?

Because to me it made more sense.

> Dave M already said sizeof(short), which is the same thing,

Ok, but that's exposing implementation.


> and I see that in net/unix/af_unix.c::unix_getname() there is:
> 
>                 *uaddr_len = sizeof(short);

I'd say that code should be fixed into using sa_family_t.

Samuel

  reply	other threads:[~2008-04-24  0:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08  2:23 Samuel Thibault
2008-03-24  4:56 ` David Miller
2008-03-24 10:43   ` Samuel Thibault
2008-03-24 11:50     ` Andi Kleen
2008-03-24 12:17       ` Samuel Thibault
2008-03-24 12:27         ` Samuel Thibault
2008-03-31  4:00           ` Michael Kerrisk
2008-03-31  9:44             ` Samuel Thibault
2008-03-31 18:51               ` Michael Kerrisk
2008-04-18 16:52             ` Michael Kerrisk
2008-04-24  0:16               ` Samuel Thibault [this message]
2008-04-24  8:31                 ` Michael Kerrisk
2008-04-26  1:44                   ` Samuel Thibault
2008-04-27  5:54                     ` David Miller
2008-05-12 13:10                       ` Michael Kerrisk
2008-05-12 13:20                         ` Samuel Thibault
2008-03-24 20:23     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424001656.GM4825@implementation \
    --to=samuel.thibault@ens-lyon.org \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=mtk.manpages@googlemail.com \
    --subject='Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).