LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH2] Basic braille screen reader support
Date: Thu, 24 Apr 2008 11:21:26 +0100	[thread overview]
Message-ID: <20080424112126.674acf7d@the-village.bc.nu> (raw)
In-Reply-To: <20080424003900.GO4825@implementation>

On Thu, 24 Apr 2008 01:39:00 +0100
Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:

> Hello,
> 
> Could the basic braille screen reader be pushed to 2.6.26?
> 
> Else, could at least the patch below be applied, so that people can
> compile external accessibility modules a lot more easily? (no need to
> patch vanilla kernel, which is a huge win for people who already have a
> hard time just using their computer...)
> 
> Samuel
> 
> Export functions typically used by screen reading modules.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Seems the right small set of changes to get us started with the real
merge and its useful for the tty cleanup to have these exports visible so
I know what will affect others.

Acked-by: Alan Cox <alan@redhat.com>


> 
> diff -ur linux-2.6.24.1-orig/drivers/char/consolemap.c linux-2.6.24.1-perso/drivers/char/consolemap.c
> --- linux-2.6.24.1-orig/drivers/char/consolemap.c	2008-01-25 09:32:05.000000000 +0100
> +++ linux-2.6.24.1-perso/drivers/char/consolemap.c	2008-02-03 22:27:04.000000000 +0100
> @@ -277,6 +277,7 @@
>  			return p->inverse_translations[m][glyph];
>  	}
>  }
> +EXPORT_SYMBOL_GPL(inverse_translate);
>  
>  static void update_user_maps(void)
>  {
> diff -ur linux-2.6.24.1-orig/drivers/char/keyboard.c linux-2.6.24.1-perso/drivers/char/keyboard.c
> --- linux-2.6.24.1-orig/drivers/char/keyboard.c	2008-01-25 09:32:06.000000000 +0100
> +++ linux-2.6.24.1-perso/drivers/char/keyboard.c	2008-02-04 03:44:37.000000000 +0100
> @@ -110,6 +110,7 @@
>  const int NR_TYPES = ARRAY_SIZE(max_vals);
>  
>  struct kbd_struct kbd_table[MAX_NR_CONSOLES];
> +EXPORT_SYMBOL_GPL(kbd_table);
>  static struct kbd_struct *kbd = kbd_table;
>  
>  struct vt_spawn_console vt_spawn_con = {
> @@ -260,6 +261,7 @@
>  	} else
>  		kd_nosound(0);
>  }
> +EXPORT_SYMBOL_GPL(kd_mksound);
>  
>  /*
>   * Setting the keyboard rate.
> diff -ur linux-2.6.24.1-orig/drivers/char/vt.c linux-2.6.24.1-perso/drivers/char/vt.c
> --- linux-2.6.24.1-orig/drivers/char/vt.c	2008-01-25 09:32:06.000000000 +0100
> +++ linux-2.6.24.1-perso/drivers/char/vt.c	2008-02-03 22:27:04.000000000 +0100
> @@ -3982,6 +3982,7 @@
>  		c |= 0x100;
>  	return c;
>  }
> +EXPORT_SYMBOL_GPL(screen_glyph);
>  
>  /* used by vcs - note the word offset */
>  unsigned short *screen_pos(struct vc_data *vc, int w_offset, int viewed)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
--
	"Alan, I'm getting a bit worried about you."
				-- Linus Torvalds

  parent reply	other threads:[~2008-04-24 10:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04  3:18 [PATCH] " Samuel Thibault
2008-02-04  3:22 ` Samuel Thibault
2008-02-04 17:10 ` Greg KH
2008-02-04 17:24   ` Samuel Thibault
2008-02-04 18:06     ` Greg KH
2008-02-04 18:15       ` Samuel Thibault
2008-02-04 18:27         ` Greg KH
2008-02-05 22:00 ` [PATCH,RESEND] " Samuel Thibault
2008-02-06  0:58   ` Andrew Morton
2008-02-06  2:04     ` Samuel Thibault
2008-02-22  0:28       ` [PATCH2] " Samuel Thibault
2008-02-23  8:04         ` Andrew Morton
2008-02-23 13:10           ` Samuel Thibault
2008-02-23 13:15             ` [PATCH] Braille screen reader fixes Samuel Thibault
2008-02-23 13:17             ` [PATCH] Braille screen reader documentation Samuel Thibault
2008-04-24  0:39             ` [PATCH2] Basic braille screen reader support Samuel Thibault
2008-04-24  4:46               ` Andrew Morton
2008-04-24 10:21               ` Alan Cox [this message]
2008-04-24 11:09                 ` Samuel Thibault
2008-03-19 18:57   ` [mmotm build error] Re: [PATCH,RESEND] " Randy Dunlap
2008-03-20  2:07     ` Samuel Thibault
2008-03-20  4:19       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424112126.674acf7d@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=dtor@mail.ru \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel.thibault@ens-lyon.org \
    --subject='Re: [PATCH2] Basic braille screen reader support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).