LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Michael Kerrisk <mtk.manpages@googlemail.com>,
	Andi Kleen <andi@firstfloor.org>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen
Date: Sat, 26 Apr 2008 02:44:45 +0100	[thread overview]
Message-ID: <20080426014445.GD4792@implementation> (raw)
In-Reply-To: <517f3f820804240131v3466713bi70d0eb0fb1f5cd8d@mail.gmail.com>

Michael Kerrisk, le Thu 24 Apr 2008 10:31:15 +0200, a écrit :
> >  > and I see that in net/unix/af_unix.c::unix_getname() there is:
> >  >
> >
> > >                 *uaddr_len = sizeof(short);
> >
> >  I'd say that code should be fixed into using sa_family_t.
> 
> Is there a patch for this?

Here it is



AF_UNIX: make unix_getname use sizeof(sunaddr->sun_family) instead of
sizeof(short).

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

--- linux/net/unix/af_unix.c.orig	2008-04-26 02:41:45.000000000 +0100
+++ linux/net/unix/af_unix.c	2008-04-26 02:42:07.000000000 +0100
@@ -1256,7 +1256,7 @@ static int unix_getname(struct socket *s
 	if (!u->addr) {
 		sunaddr->sun_family = AF_UNIX;
 		sunaddr->sun_path[0] = 0;
-		*uaddr_len = sizeof(short);
+		*uaddr_len = sizeof(sunaddr->sun_family);
 	} else {
 		struct unix_address *addr = u->addr;
 

  reply	other threads:[~2008-04-26  1:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08  2:23 Samuel Thibault
2008-03-24  4:56 ` David Miller
2008-03-24 10:43   ` Samuel Thibault
2008-03-24 11:50     ` Andi Kleen
2008-03-24 12:17       ` Samuel Thibault
2008-03-24 12:27         ` Samuel Thibault
2008-03-31  4:00           ` Michael Kerrisk
2008-03-31  9:44             ` Samuel Thibault
2008-03-31 18:51               ` Michael Kerrisk
2008-04-18 16:52             ` Michael Kerrisk
2008-04-24  0:16               ` Samuel Thibault
2008-04-24  8:31                 ` Michael Kerrisk
2008-04-26  1:44                   ` Samuel Thibault [this message]
2008-04-27  5:54                     ` David Miller
2008-05-12 13:10                       ` Michael Kerrisk
2008-05-12 13:20                         ` Samuel Thibault
2008-03-24 20:23     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080426014445.GD4792@implementation \
    --to=samuel.thibault@ens-lyon.org \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=mtk.manpages@googlemail.com \
    --subject='Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).