LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] unexport journal_update_superblock
@ 2008-05-05 18:26 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-05-05 18:26 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 22 Apr 2008
- 14 Apr 2008
- 31 Mar 2008
- 27 Feb 2008
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] unexport journal_update_superblock
@ 2008-06-25 16:26 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-06-25 16:26 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 5 May 2008
- 22 Apr 2008
- 14 Apr 2008
- 31 Mar 2008
- 27 Feb 2008
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] unexport journal_update_superblock
@ 2008-04-21 21:32 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-21 21:32 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 14 Apr 2008
- 31 Mar 2008
- 27 Feb 2008
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] unexport journal_update_superblock
@ 2008-04-14 18:13 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-14 18:13 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 31 Mar 2008
- 27 Feb 2008
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] unexport journal_update_superblock
@ 2008-03-30 22:40 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-03-30 22:40 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 27 Feb 2008
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] fs/jbd/journal.c: cleanups
@ 2008-02-17 8:19 Adrian Bunk
2008-02-18 7:04 ` Andreas Dilger
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-02-17 8:19 UTC (permalink / raw)
To: sct, akpm, adilger; +Cc: linux-ext4, linux-kernel
This patch contains the following cleanups:
- make the following needlessly global function static:
- journal_check_used_features()
- remove the following unused EXPORT_SYMBOL's:
- journal_set_features
- journal_update_superblock
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch has been sent on:
- 16 May 2006
- 1 May 2006
- 23 Apr 2006
fs/jbd/journal.c | 9 ++++-----
include/linux/jbd.h | 2 --
2 files changed, 4 insertions(+), 7 deletions(-)
4b48b0ddcc5e710bbc1e89e219db69000225ee28 diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..b230288 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -62,13 +62,10 @@ EXPORT_SYMBOL(journal_revoke);
EXPORT_SYMBOL(journal_init_dev);
EXPORT_SYMBOL(journal_init_inode);
EXPORT_SYMBOL(journal_update_format);
-EXPORT_SYMBOL(journal_check_used_features);
EXPORT_SYMBOL(journal_check_available_features);
-EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
@@ -1174,8 +1171,10 @@ void journal_destroy(journal_t *journal)
* features. Return true (non-zero) if it does.
**/
-int journal_check_used_features (journal_t *journal, unsigned long compat,
- unsigned long ro, unsigned long incompat)
+static int journal_check_used_features(journal_t *journal,
+ unsigned long compat,
+ unsigned long ro,
+ unsigned long incompat)
{
journal_superblock_t *sb;
diff --git a/include/linux/jbd.h b/include/linux/jbd.h
index b18fd3b..e8f81ab 100644
--- a/include/linux/jbd.h
+++ b/include/linux/jbd.h
@@ -909,8 +909,6 @@ extern journal_t * journal_init_dev(struct block_device *bdev,
int start, int len, int bsize);
extern journal_t * journal_init_inode (struct inode *);
extern int journal_update_format (journal_t *);
-extern int journal_check_used_features
- (journal_t *, unsigned long, unsigned long, unsigned long);
extern int journal_check_available_features
(journal_t *, unsigned long, unsigned long, unsigned long);
extern int journal_set_features
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] fs/jbd/journal.c: cleanups
2008-02-17 8:19 [2.6 patch] fs/jbd/journal.c: cleanups Adrian Bunk
@ 2008-02-18 7:04 ` Andreas Dilger
2008-02-27 21:20 ` [2.6 patch] unexport journal_update_superblock Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Dilger @ 2008-02-18 7:04 UTC (permalink / raw)
To: Adrian Bunk; +Cc: sct, akpm, linux-ext4, linux-kernel
On Feb 17, 2008 10:19 +0200, Adrian Bunk wrote:
> This patch contains the following cleanups:
> - make the following needlessly global function static:
> - journal_check_used_features()
> - remove the following unused EXPORT_SYMBOL's:
> - journal_set_features
> - journal_update_superblock
Nack. I don't object to un-exporting journal_update_superblock(), because
that is pretty internal, but the other functions are intended specifically
for use by code outside of JBD. For example, the journal checksum patch for
ext3/4 uses journal_set_features() to turn on features in the JBD superblock.
Similarly, for 64-bit support in ext4 uses journal_set_features() to set
a 64-bit feature flag in the journal superblock.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] unexport journal_update_superblock
2008-02-18 7:04 ` Andreas Dilger
@ 2008-02-27 21:20 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-02-27 21:20 UTC (permalink / raw)
To: Andreas Dilger; +Cc: sct, akpm, linux-ext4, linux-kernel
On Mon, Feb 18, 2008 at 12:04:39AM -0700, Andreas Dilger wrote:
> On Feb 17, 2008 10:19 +0200, Adrian Bunk wrote:
> > This patch contains the following cleanups:
> > - make the following needlessly global function static:
> > - journal_check_used_features()
> > - remove the following unused EXPORT_SYMBOL's:
> > - journal_set_features
> > - journal_update_superblock
>
> Nack. I don't object to un-exporting journal_update_superblock(), because
> that is pretty internal, but the other functions are intended specifically
> for use by code outside of JBD. For example, the journal checksum patch for
> ext3/4 uses journal_set_features() to turn on features in the JBD superblock.
>...
A patch that only unexports journal_update_superblock is below.
> Cheers, Andreas
cu
Adrian
<-- snip -->
This patch removes the unused EXPORT_SYMBOL(journal_update_superblock).
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 3943a89..5c2ebb7 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features);
EXPORT_SYMBOL(journal_create);
EXPORT_SYMBOL(journal_load);
EXPORT_SYMBOL(journal_destroy);
-EXPORT_SYMBOL(journal_update_superblock);
EXPORT_SYMBOL(journal_abort);
EXPORT_SYMBOL(journal_errno);
EXPORT_SYMBOL(journal_ack_err);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-06-25 16:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-05-05 18:26 [2.6 patch] unexport journal_update_superblock Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2008-06-25 16:26 Adrian Bunk
2008-04-21 21:32 Adrian Bunk
2008-04-14 18:13 Adrian Bunk
2008-03-30 22:40 Adrian Bunk
2008-02-17 8:19 [2.6 patch] fs/jbd/journal.c: cleanups Adrian Bunk
2008-02-18 7:04 ` Andreas Dilger
2008-02-27 21:20 ` [2.6 patch] unexport journal_update_superblock Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).