LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>
Date: Mon, 5 May 2008 14:46:11 -0400 [thread overview]
Message-ID: <20080505184610.GA23910@infradead.org> (raw)
In-Reply-To: <20080505182749.GJ17139@cs181133002.pp.htv.fi>
On Mon, May 05, 2008 at 09:27:50PM +0300, Adrian Bunk wrote:
> Every file should include the headers containing the externs for its
> global code (in this case for struct generic_file_vm_ops).
Please move generic_file_vm_ops to fs.h instead please, it doesn't
belong into a fle called ramfs.h, and neither should filemap.c include
such a header.
next prev parent reply other threads:[~2008-05-05 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:27 Adrian Bunk
2008-05-05 18:46 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-21 21:32 Adrian Bunk
2008-04-14 18:14 Adrian Bunk
2008-03-30 22:49 Adrian Bunk
2008-02-25 0:08 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505184610.GA23910@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [2.6 patch] mm/filemap.c should #include <linux/ramfs.h>' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).