LKML Archive on
help / color / mirror / Atom feed
From: Robert Richter <>
To: Arjan van de Ven <>
Cc: Thomas Gleixner <>,
	Ingo Molnar <>, "H. Peter Anvin" <>,
	LKML <>,
	Stephane Eranian <>
Subject: Re: [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions
Date: Thu, 19 Jun 2008 19:00:56 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


do you see a way of how to get these EXPORT_SYMBOLs mainline? Better
use EXPORT_SYMBOL_GPL? Or is it common sense to add EXPORT_SYMBOLs to
mainline not until there are already use cases in the mainline?

At least the IBS symbol is needed for Perfmon but potentially also for
OProfile. This will allow the use of loadable Perfmon kernel modules,
especially if some lightwight Perfmon features are already upstream.

Also, APIC setup is more general and not Perfmon related. So I
think the Perfmon tree is not the right place to keep the code.

I don't know, if there is a use case for loadable MCE modules. We
could skip this, but as I said, code consistency...



On 14.02.08 08:47:49, Arjan van de Ven wrote:
> > > > +EXPORT_SYMBOL(setup_APIC_eilvt_ibs);
> > > 
> > > which modules would even consider using any of these?
> > > Doesn't sound like something we should export..
> > 
> > For IBS it is Perfmon. See here:
> >;a=commit;h=7caef3e19d17349f869884f5adf7c9823e32ade7
> > 
> perfmon doesn't seem to go anywhere lately, so realistically this chunk should be part of the perfmon tree.


> > MCE export has been added for consistency reasons to allow modules to
> > enable MCE.
> no module does that right now, nor should it. MCE is really something the core kernel should do right?
> "consistency reasons" isn't "just export everything used or not", it's "oh this makes sense as part of a well
> thought out, generic consistent api". This one isn't./


Advanced Micro Devices, Inc.
Operating System Research Center

  reply	other threads:[~2008-06-19 17:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 15:19 [patch 0/2] x86: Add AMD Barcelona extended interrupt support for 32bit Robert Richter
2008-02-13 15:19 ` [patch 2/2] x86: apic: Extended interrupt LVT support for AMD Barcelona (32bit) Robert Richter
2008-02-17 17:07   ` Ingo Molnar
2008-02-13 15:19 ` [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions Robert Richter
2008-02-13 22:32   ` Arjan van de Ven
2008-02-14  9:40     ` Robert Richter
2008-02-14 16:47       ` Arjan van de Ven
2008-06-19 17:00         ` Robert Richter [this message]
2008-06-20  2:36           ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [patch 1/2] x86: apic: Export symbols for extended interrupt LVT functions' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).