LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frank Mayhar <fmayhar@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Roland McGrath <roland@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
Date: Sun, 14 Sep 2008 17:12:51 +0200 [thread overview]
Message-ID: <20080914151251.GA28507@elte.hu> (raw)
In-Reply-To: <20080914150651.GK12522@elte.hu>
a couple of fixlets below, pointed out by scripts/checkpatch.pl.
Ingo
---------->
>From 5ce73a4a5a4893a1aa4cdeed1b1a5a6de42c43b6 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sun, 14 Sep 2008 17:11:46 +0200
Subject: [PATCH] timers: fix itimer/many thread hang, cleanups
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/sched.h | 2 +-
kernel/posix-cpu-timers.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index ed355f0..7ce8d4e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -430,7 +430,7 @@ struct pacct_struct {
* @utime: time spent in user mode, in &cputime_t units
* @stime: time spent in kernel mode, in &cputime_t units
* @sum_exec_runtime: total time spent on the CPU, in nanoseconds
- *
+ *
* This structure groups together three kinds of CPU time that are
* tracked for threads and thread groups. Most things considering
* CPU time want to group these counts together and treat all three
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index dba1c33..9a7ea04 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -94,7 +94,7 @@ void update_rlimit_cpu(unsigned long rlim_new)
cputime = secs_to_cputime(rlim_new);
if (cputime_eq(current->signal->it_prof_expires, cputime_zero) ||
- cputime_lt(current->signal->it_prof_expires, cputime)) {
+ cputime_lt(current->signal->it_prof_expires, cputime)) {
spin_lock_irq(¤t->sighand->siglock);
set_process_cpu_timer(current, CPUCLOCK_PROF, &cputime, NULL);
spin_unlock_irq(¤t->sighand->siglock);
@@ -1372,9 +1372,9 @@ void run_posix_cpu_timers(struct task_struct *tsk)
* tsk->signal is non-NULL; this probably can't happen but cover the
* possibility anyway.
*/
- if (unlikely(!sig) || !fastpath_timer_check(tsk, sig)) {
+ if (unlikely(!sig) || !fastpath_timer_check(tsk, sig))
return;
- }
+
sighand = lock_task_sighand(tsk, &flags);
if (likely(sighand)) {
/*
next prev parent reply other threads:[~2008-09-14 15:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 16:54 Frank Mayhar
2008-09-12 20:27 ` Andrew Morton
2008-09-14 15:06 ` Ingo Molnar
2008-09-14 15:07 ` [PATCH] timers: fix itimer/many thread hang, fix Ingo Molnar
2008-09-14 15:09 ` [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang Ingo Molnar
2008-09-15 18:09 ` Frank Mayhar
2008-09-16 8:41 ` Ingo Molnar
2008-09-17 19:03 ` Frank Mayhar
2008-09-17 19:13 ` Roland McGrath
2008-09-17 20:12 ` Frank Mayhar
2008-09-18 10:23 ` Ingo Molnar
2008-09-18 13:50 ` Frank Mayhar
2008-09-22 20:22 ` [PATCH 2.6.27-rc5 re-resubmit] " Frank Mayhar
2008-09-23 11:40 ` Ingo Molnar
2008-09-23 12:52 ` [boot crash] " Ingo Molnar
2008-09-23 13:59 ` Oleg Nesterov
2008-09-23 16:09 ` Frank Mayhar
2008-09-23 22:56 ` Frank Mayhar
2008-09-24 21:23 ` [PATCH 2.6.27-rc5 incremental " Frank Mayhar
2008-09-27 18:08 ` Ingo Molnar
2008-09-30 6:33 ` Ingo Molnar
2008-09-30 16:36 ` Frank Mayhar
2008-10-01 16:20 ` Frank Mayhar
2008-10-02 9:43 ` Ingo Molnar
2008-09-14 15:12 ` Ingo Molnar [this message]
2008-09-14 15:14 ` [PATCH 2.6.27-rc5 resubmit] " Ingo Molnar
2008-09-14 19:31 ` Roland McGrath
2008-09-15 6:41 ` Ingo Molnar
2008-09-15 17:59 ` Frank Mayhar
2008-09-16 8:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080914151251.GA28507@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--subject='Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).