LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frank Mayhar <fmayhar@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Roland McGrath <roland@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
Date: Tue, 16 Sep 2008 10:41:43 +0200	[thread overview]
Message-ID: <20080916084143.GC17287@elte.hu> (raw)
In-Reply-To: <1221502142.19012.35.camel@bobble.smo.corp.google.com>


* Frank Mayhar <fmayhar@google.com> wrote:

> > the wider question is, shouldnt the UP case be just the same as the 
> > SMP case? Especially the type assymetry struct thread_group_cputime 
> > looks ugly. (and assymetries like that tend to be a constant source 
> > of breakage like the one below.)
> 
> I'm not overly fond of this one, either; I did it at Roland's 
> suggestion (it's all _his_ fault, yeah, _that's_ the ticket! :-); his 
> opinion IIRC was that the UP case will perform better without the 
> extra pointer dereferences.  I agree that it's a potential source of 
> pain such as the one you point out.

i dont know ... 

lets try that simplification as a delta patch, ok? Please check the 
before/after size of 'vmlinux' in a 'make defconfig' [with SMP disabled 
after make defconfig] UP build. If there's visible size difference then 
Roland's point holds.

	Ingo

  reply	other threads:[~2008-09-16  8:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12 16:54 Frank Mayhar
2008-09-12 20:27 ` Andrew Morton
2008-09-14 15:06 ` Ingo Molnar
2008-09-14 15:07   ` [PATCH] timers: fix itimer/many thread hang, fix Ingo Molnar
2008-09-14 15:09   ` [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang Ingo Molnar
2008-09-15 18:09     ` Frank Mayhar
2008-09-16  8:41       ` Ingo Molnar [this message]
2008-09-17 19:03         ` Frank Mayhar
2008-09-17 19:13           ` Roland McGrath
2008-09-17 20:12             ` Frank Mayhar
2008-09-18 10:23           ` Ingo Molnar
2008-09-18 13:50             ` Frank Mayhar
2008-09-22 20:22             ` [PATCH 2.6.27-rc5 re-resubmit] " Frank Mayhar
2008-09-23 11:40               ` Ingo Molnar
2008-09-23 12:52                 ` [boot crash] " Ingo Molnar
2008-09-23 13:59                 ` Oleg Nesterov
2008-09-23 16:09                   ` Frank Mayhar
2008-09-23 22:56                   ` Frank Mayhar
2008-09-24 21:23               ` [PATCH 2.6.27-rc5 incremental " Frank Mayhar
2008-09-27 18:08                 ` Ingo Molnar
2008-09-30  6:33                 ` Ingo Molnar
2008-09-30 16:36                   ` Frank Mayhar
2008-10-01 16:20                     ` Frank Mayhar
2008-10-02  9:43                       ` Ingo Molnar
2008-09-14 15:12   ` [PATCH 2.6.27-rc5 resubmit] " Ingo Molnar
2008-09-14 15:14 ` Ingo Molnar
2008-09-14 19:31   ` Roland McGrath
2008-09-15  6:41     ` Ingo Molnar
2008-09-15 17:59       ` Frank Mayhar
2008-09-16  8:39         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080916084143.GC17287@elte.hu \
    --to=mingo@elte.hu \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fmayhar@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).