LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch 1.2.32] WAN: merge driver retina
@ 2008-07-04  6:39 Matti Linnanvuori
  2008-08-07  6:31 ` Jeff Garzik
  0 siblings, 1 reply; 5+ messages in thread
From: Matti Linnanvuori @ 2008-07-04  6:39 UTC (permalink / raw)
  To: netdev, linux-kernel, jgarzik

The following patch is based on linux-next:
http://pcidriver.googlegroups.com/web/retina-patch.txt?gda=Hj6V2UEAAAD9a223ZdyQxc6jQf5toR434ka3fTOuf9SStRjUQ9KuyGG1qiJ7UbTIup-M2XPURDRb8A7WwO6f6JZwMwSZaAwRMXXBcZFbXU7ojtsMSuO4sA
The build error and the warnings reported by David Miller have been fixed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch 1.2.32] WAN: merge driver retina
  2008-07-04  6:39 [patch 1.2.32] WAN: merge driver retina Matti Linnanvuori
@ 2008-08-07  6:31 ` Jeff Garzik
       [not found]   ` <ca0148c30808072334w5d2d8216s37152621b4aa8ebf@mail.gmail.com>
  0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2008-08-07  6:31 UTC (permalink / raw)
  To: Matti Linnanvuori; +Cc: netdev, linux-kernel

Matti Linnanvuori wrote:
> The following patch is based on linux-next:
> http://pcidriver.googlegroups.com/web/retina-patch.txt?gda=Hj6V2UEAAAD9a223ZdyQxc6jQf5toR434ka3fTOuf9SStRjUQ9KuyGG1qiJ7UbTIup-M2XPURDRb8A7WwO6f6JZwMwSZaAwRMXXBcZFbXU7ojtsMSuO4sA
> The build error and the warnings reported by David Miller have been fixed.

The version I reviewed uses virt_to_bus(), which should not be used in 
modern drivers.  The DMA API should be used instead.

A couple months ago I created a 'retina' branch of 
jgarzik/netdev-2.6.git containing your latest code.  If you could send 
patches against that, that would be helpful in reviewing the 
improvements you make to the driver, and help us get this into the kernel.

	Jeff




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch v1.2.34] WAN: merge driver retina
       [not found]       ` <48CC57EB.9010500@pobox.com>
@ 2008-09-30  9:51         ` Matti Linnanvuori
  2008-10-16  9:34           ` Jeff Garzik
  0 siblings, 1 reply; 5+ messages in thread
From: Matti Linnanvuori @ 2008-09-30  9:51 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: netdev, linux-kernel

2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
> Changes look good, but do not apply to the 'retina' branch.  Also, the
> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
> usage.

Actually there is one call of virt_to_phys in the patch I sent.
I don't know any way to replace virt_to_phys and still use remap_pfn_range.
If all architectures support virt_to_phys, I see no reason to replace it with
something else. The driver is legacy.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch v1.2.34] WAN: merge driver retina
  2008-09-30  9:51         ` [patch v1.2.34] " Matti Linnanvuori
@ 2008-10-16  9:34           ` Jeff Garzik
  2008-10-16  9:35             ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Jeff Garzik @ 2008-10-16  9:34 UTC (permalink / raw)
  To: Matti Linnanvuori; +Cc: netdev, linux-kernel

Matti Linnanvuori wrote:
> 2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
>> Changes look good, but do not apply to the 'retina' branch.  Also, the
>> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
>> usage.
> 
> Actually there is one call of virt_to_phys in the patch I sent.
> I don't know any way to replace virt_to_phys and still use remap_pfn_range.
> If all architectures support virt_to_phys, I see no reason to replace it with
> something else. The driver is legacy.

We do not merge new drivers that use deprecated APIs.

The whole point of a deprecated API is that you wish to remove it 
eventually.

	Jeff



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch v1.2.34] WAN: merge driver retina
  2008-10-16  9:34           ` Jeff Garzik
@ 2008-10-16  9:35             ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2008-10-16  9:35 UTC (permalink / raw)
  To: jgarzik; +Cc: mattilinn, netdev, linux-kernel

From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 16 Oct 2008 05:34:08 -0400

> Matti Linnanvuori wrote:
> > 2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
> >> Changes look good, but do not apply to the 'retina' branch.  Also, the
> >> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
> >> usage.
> > Actually there is one call of virt_to_phys in the patch I sent.
> > I don't know any way to replace virt_to_phys and still use remap_pfn_range.
> > If all architectures support virt_to_phys, I see no reason to replace it with
> > something else. The driver is legacy.
> 
> We do not merge new drivers that use deprecated APIs.
> 
> The whole point of a deprecated API is that you wish to remove it eventually.

Note that virt_to_phys() is not a problem.

It's only virt_to_bus() that mustn't be used.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-10-16  9:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-04  6:39 [patch 1.2.32] WAN: merge driver retina Matti Linnanvuori
2008-08-07  6:31 ` Jeff Garzik
     [not found]   ` <ca0148c30808072334w5d2d8216s37152621b4aa8ebf@mail.gmail.com>
     [not found]     ` <ca0148c30808120246w5c2eca09u3bfa08e3ea40cfe4@mail.gmail.com>
     [not found]       ` <48CC57EB.9010500@pobox.com>
2008-09-30  9:51         ` [patch v1.2.34] " Matti Linnanvuori
2008-10-16  9:34           ` Jeff Garzik
2008-10-16  9:35             ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).