LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] mfd/wm8350: don't export static functions
@ 2008-10-16  9:47 Stephen Rothwell
  2008-10-16 12:04 ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2008-10-16  9:47 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, LKML, Linus, ppc-dev, Andrew Morton

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict

Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
elsewhere, so remove the EXPORT_SYMBOL.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/wm8350-core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index bf87f67..fbe22fb 100644
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -1128,7 +1128,6 @@ static int wm8350_create_cache(struct wm8350 *wm8350, int mode)
 out:
 	return ret;
 }
-EXPORT_SYMBOL_GPL(wm8350_create_cache);
 
 /*
  * Register a client device.  This is non-fatal since there is no need to
-- 
1.5.6.5

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mfd/wm8350: don't export static functions
  2008-10-16  9:47 [PATCH] mfd/wm8350: don't export static functions Stephen Rothwell
@ 2008-10-16 12:04 ` Mark Brown
  2008-10-22  9:31   ` Stephen Rothwell
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2008-10-16 12:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, linux-next, LKML, Linus, ppc-dev, Andrew Morton

On Thu, Oct 16, 2008 at 08:47:54PM +1100, Stephen Rothwell wrote:
> Today's linux-next build (powerpc allyesconfig) failed like this:

> drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict

> Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
> support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
> elsewhere, so remove the EXPORT_SYMBOL.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mfd/wm8350: don't export static functions
  2008-10-16 12:04 ` Mark Brown
@ 2008-10-22  9:31   ` Stephen Rothwell
  2008-10-22  9:37     ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2008-10-22  9:31 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, LKML, Linus, ppc-dev, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Hi Mark,

On Thu, 16 Oct 2008 13:04:16 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Thu, Oct 16, 2008 at 08:47:54PM +1100, Stephen Rothwell wrote:
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> 
> > drivers/mfd/wm8350-core.c:1131: error: __ksymtab_wm8350_create_cache causes a section type conflict
> 
> > Caused by commit 89b4012befb1abca5e86d232bc0e2a797b0d9825 ("mfd: Core
> > support for the WM8350 AudioPlus PMIC"). wm8350_create_cache is not used
> > elsewhere, so remove the EXPORT_SYMBOL.
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

I thought that this had been applied, but I have had to apply it to my
tree today again.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mfd/wm8350: don't export static functions
  2008-10-22  9:31   ` Stephen Rothwell
@ 2008-10-22  9:37     ` Mark Brown
  2008-10-22  9:54       ` Stephen Rothwell
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2008-10-22  9:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Liam Girdwood, linux-next, LKML, Linus, ppc-dev, Andrew Morton

On Wed, Oct 22, 2008 at 08:31:12PM +1100, Stephen Rothwell wrote:

> I thought that this had been applied, but I have had to apply it to my
> tree today again.

Samuel doesn't seem to have picked it up (though looking at the CC list
you've not sent it to him).  I'm going to push another batch of stuff to
him later today, hopefully he will pick it up then.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mfd/wm8350: don't export static functions
  2008-10-22  9:37     ` Mark Brown
@ 2008-10-22  9:54       ` Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2008-10-22  9:54 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, linux-next, LKML, Linus, ppc-dev, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hi Mark,

On Wed, 22 Oct 2008 10:37:22 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Wed, Oct 22, 2008 at 08:31:12PM +1100, Stephen Rothwell wrote:
> 
> > I thought that this had been applied, but I have had to apply it to my
> > tree today again.
> 
> Samuel doesn't seem to have picked it up (though looking at the CC list
> you've not sent it to him).  I'm going to push another batch of stuff to
> him later today, hopefully he will pick it up then.

OK, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-10-22  9:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-16  9:47 [PATCH] mfd/wm8350: don't export static functions Stephen Rothwell
2008-10-16 12:04 ` Mark Brown
2008-10-22  9:31   ` Stephen Rothwell
2008-10-22  9:37     ` Mark Brown
2008-10-22  9:54       ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).