LKML Archive on
help / color / mirror / Atom feed
From: Andreas Herrmann <>
To: Ingo Molnar <>, Thomas Gleixner <>
	Joerg Roedel <>
Subject: [PATCH] x86: amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE_ENTRY errors
Date: Thu, 16 Oct 2008 16:27:36 +0200	[thread overview]
Message-ID: <> (raw)

We are on 64-bit so better use u64 instead of u32 to deal with

static void __init iommu_set_device_table(struct amd_iommu *iommu)
        u64 entry;
        entry = virt_to_phys(amd_iommu_dev_table);

(I am wondering why gcc 4.2.x did not warn about the assignment
between u32 and unsigned long.)

Cc: Joerg Roedel <>
Signed-off-by: Andreas Herrmann <>

 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch is against today's tip/x86/amd-iommu
Joerg is on vacation. That is why I post this patch
directly to you.



diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index a69cc0f..bccd0ef 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -210,7 +210,7 @@ static void __init iommu_set_exclusion_range(struct amd_iommu *iommu)
 /* Programs the physical address of the device table into the IOMMU hardware */
 static void __init iommu_set_device_table(struct amd_iommu *iommu)
-	u32 entry;
+	u64 entry;
 	BUG_ON(iommu->mmio_base == NULL);

             reply	other threads:[~2008-10-16 14:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 14:27 Andreas Herrmann [this message]
2008-10-16 14:59 ` Joerg Roedel
2008-10-20 16:06   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] x86: amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE_ENTRY errors' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).