LKML Archive on
help / color / mirror / Atom feed
* [PATCH] tpm: don't export static functions
@ 2008-10-16  9:36 Stephen Rothwell
  0 siblings, 0 replies; only message in thread
From: Stephen Rothwell @ 2008-10-16  9:36 UTC (permalink / raw)
  To: Linus, Andrew Morton
  Cc: linux-next, LKML, ppc-dev, Rajiv Andrade, James Morris

Today's linux-next build (powerpc_allyesconfig) failed like this:

drivers/char/tpm/tpm.c:1162: error: __ksymtab_tpm_dev_release causes a section type conflict

Caused by commit 253115b71fa06330bd58afbe01ccaf763a8a0cf1 ("The
tpm_dev_release function is only called for platform devices, not pnp")
which exported a static function.

Signed-off-by: Stephen Rothwell <>
 drivers/char/tpm/tpm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 1fee703..f61c9fe 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -1150,7 +1150,7 @@ EXPORT_SYMBOL_GPL(tpm_dev_vendor_release);
  * Once all references to platform device are down to 0,
  * release all allocated structures.
-static void tpm_dev_release(struct device *dev)
+void tpm_dev_release(struct device *dev)
 	struct tpm_chip *chip = dev_get_drvdata(dev);

Stephen Rothwell          

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-16 10:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-16  9:36 [PATCH] tpm: don't export static functions Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).