LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [Patch] kernel/kallsyms.c: fix double return's
@ 2008-10-10  9:43 Américo Wang
  2008-10-16 11:32 ` Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Américo Wang @ 2008-10-10  9:43 UTC (permalink / raw)
  To: LKML; +Cc: Andrew Morton, Rusty Russell


Commit 6dd06c9fbe025f542bce4cdb91790c0f91962722 introduced double
returns in the function kallsyms_lookup(), it's weird.
The second one should be removed.

Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>

---
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index 38fc10a..5072cf1 100644
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -260,7 +260,6 @@ const char *kallsyms_lookup(unsigned long addr,
 	/* see if it's in a module */
 	return module_address_lookup(addr, symbolsize, offset, modname,
 				     namebuf);
-	return NULL;
 }
 
 int lookup_symbol_name(unsigned long addr, char *symname)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] kernel/kallsyms.c: fix double return's
  2008-10-10  9:43 [Patch] kernel/kallsyms.c: fix double return's Américo Wang
@ 2008-10-16 11:32 ` Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-10-16 11:32 UTC (permalink / raw)
  To: Américo Wang; +Cc: LKML, Andrew Morton

On Friday 10 October 2008 20:43:03 Américo Wang wrote:
> Commit 6dd06c9fbe025f542bce4cdb91790c0f91962722 introduced double
> returns in the function kallsyms_lookup(), it's weird.
> The second one should be removed.
>
> Signed-off-by: WANG Cong <wangcong@zeuux.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>

Yeah, weird.

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks!
Rusty.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-16 11:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-10  9:43 [Patch] kernel/kallsyms.c: fix double return's Américo Wang
2008-10-16 11:32 ` Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).