LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Adam Tlałka" <atlka@pg.gda.pl>
To: "Adam Tlałka" <atlka@pg.gda.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Bodo Eggert <7eggert@gmx.de>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH 0/5] SIGWINCH problem with terminal apps still alive
Date: Fri, 17 Oct 2008 10:39:37 +0200	[thread overview]
Message-ID: <20081017103937.3e7876c9@merlin.oi.pg.gda.pl> (raw)
In-Reply-To: <20081016134303.686adea2@merlin.oi.pg.gda.pl>

Welcome,

If we want to be more consistent with console behaviour the ptm/pty
behaviour should be similar. In my opinion it could be done
be using some kind of callback function which could be registered by
the program which rules ptm. Then it could be activated through
tty->ops->resize from tiocswinsz in tty_io. The default will be not set
so we get current typical behaviour.

We could also use some default function which calls tty_do_resize() if
called from master side and does nothing if called from slave side
so there is no change because real terminal sizes are not changed.
The terminal emulator program should register its callback
function which leads to proper resize and then signal generating by
ioctl(ptm,TIOCSWINSZ,). It is different from current behaviour but more
usable and sane IMHO.

The current ,,proper'' behaviour is inconsistent. For example you can
do "stty rows 0" on console and there is no change at all and no error
reporting too. With pty we get SIGWINCH signal and variable rows is
set to 0. Of course the real physical terminal is not changed at all.


Regards

-- 
Adam Tlałka       mailto:atlka@pg.gda.pl    ^v^ ^v^ ^v^
System  & Network Administration Group       - - - ~~~~~~
Computer Center, Gdańsk University of Technology, Poland

      reply	other threads:[~2008-10-17  8:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bjXel-4CU-17@gated-at.bofh.it>
     [not found] ` <bjYap-5Q0-25@gated-at.bofh.it>
     [not found]   ` <bk30i-3Gx-1@gated-at.bofh.it>
     [not found]     ` <bk6AV-8ms-7@gated-at.bofh.it>
     [not found]       ` <bkrvO-1HF-49@gated-at.bofh.it>
     [not found]         ` <blePJ-6rI-3@gated-at.bofh.it>
     [not found]           ` <blmDC-7ZU-7@gated-at.bofh.it>
2008-10-11 14:04             ` [PATCH 0/1] " Bodo Eggert
2008-10-11 17:58               ` Alan Cox
2008-10-12 12:32                 ` [PATCH 0/2] " Adam Tlałka
2008-10-12 14:22                   ` Alan Cox
2008-10-12 17:59                     ` Adam Tlałka
2008-10-12 18:03                       ` Alan Cox
2008-10-12 19:01                         ` Adam Tlałka
2008-10-12 20:22                           ` Alan Cox
2008-10-13  9:59                             ` Bodo Eggert
2008-10-13 10:01                               ` Alan Cox
2008-10-13 12:07                                 ` Bodo Eggert
2008-10-14 12:51                                   ` [PATCH 0/3] " Adam Tlałka
2008-10-14 14:11                                     ` [PATCH 0/4] " Adam Tlałka
2008-10-16 10:27                                       ` [PATCH 0/5] " Adam Tlałka
2008-10-16 10:52                                         ` Alan Cox
2008-10-16 11:43                                           ` Adam Tlałka
2008-10-17  8:39                                             ` Adam Tlałka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017103937.3e7876c9@merlin.oi.pg.gda.pl \
    --to=atlka@pg.gda.pl \
    --cc=7eggert@gmx.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: [PATCH 0/5] SIGWINCH problem with terminal apps still alive' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).