From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753534AbYJQLTU (ORCPT ); Fri, 17 Oct 2008 07:19:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752782AbYJQLTL (ORCPT ); Fri, 17 Oct 2008 07:19:11 -0400 Received: from bu3sch.de ([62.75.166.246]:56733 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751772AbYJQLTK (ORCPT ); Fri, 17 Oct 2008 07:19:10 -0400 From: Michael Buesch To: "Magnus Damm" Subject: Re: [PATCH v3] Add SPI over GPIO driver Date: Fri, 17 Oct 2008 13:18:32 +0200 User-Agent: KMail/1.9.6 (enterprise 0.20070907.709405) Cc: "David Brownell" , "Andrew Morton" , "Stephen Rothwell" , linux-kernel , "Piot Skamruk" References: <200807202146.12759.mb@bu3sch.de> <200810171052.54823.mb@bu3sch.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810171318.32306.mb@bu3sch.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 17 October 2008 11:52:32 Magnus Damm wrote: > [removed closed openwrt-devel list] > > On Fri, Oct 17, 2008 at 5:52 PM, Michael Buesch wrote: > > On Friday 17 October 2008 05:14:26 Magnus Damm wrote: > >> On Mon, Jul 21, 2008 at 4:46 AM, Michael Buesch wrote: > >> > This adds a driver that lets you drive an SPI bus over > >> > generic GPIO pins. > >> > > >> > Signed-off-by: Michael Buesch > >> > >> Very useful. Fits my shiny new GPIO implementation for SuperH like a glove. > >> > >> Michael, as you know, I have some SuperH board code that makes use of > >> this driver. Are there any outstanding issues with this driver that I > >> can help resolving? > > > > bool cs_activelow should probably be removed from struct spi_gpio_platform_data. > > > > I think cs always is activelow, so we can simply hardcode this in spi_gpio_chipselect() > > Really? There _must_ be chips out there that want active high CS! > I'd rather keep the activelow option or maybe turn in into activehigh instead. Ok, I dunno. I never saw one. All of my SPI stuff is activelow. So well, let's keep it. > > If you want to do this, please feel free to do so. > > I currently don't have the time for this. > > The rest of the driver is fine with me. > > Ok, thank you. > > David or Andrew, any change of getting this merged as-is somehow? Thanks! Yes, please merge it. -- Greetings Michael.