LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bastian Blank <bastian@waldi.eu.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arch@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [patch 2/2] introduce vdso on s390
Date: Fri, 17 Oct 2008 17:34:36 +0200	[thread overview]
Message-ID: <20081017153436.GA17116@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <20081015175305.332585239@de.ibm.com>

On Wed, Oct 15, 2008 at 07:45:08PM +0200, Martin Schwidefsky wrote:
> +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> +{
> +	if (clock != &clocksource_tod)
> +		return;
> +
> +	/* Make userspace gettimeofday spin until we're done. */
> +	++vdso_data->tb_update_count;
> +	smp_mb();
> +	vdso_data->xtime_tod_stamp = clock->cycle_last;
> +	vdso_data->xtime_clock_sec = xtime.tv_sec;
> +	vdso_data->xtime_clock_nsec = xtime.tv_nsec;
> +	vdso_data->wtom_clock_sec = wall_to_monotonic.tv_sec;
> +	vdso_data->wtom_clock_nsec = wall_to_monotonic.tv_nsec;
> +	smp_wmb();

Different barriers?

> +	++(vdso_data->tb_update_count);

Why ++(...)?

Bastian

-- 
Either one of us, by himself, is expendable.  Both of us are not.
		-- Kirk, "The Devil in the Dark", stardate 3196.1

  reply	other threads:[~2008-10-17 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15 17:45 [patch 0/2] vdso support for s390 Martin Schwidefsky
2008-10-15 17:45 ` [patch 1/2] arch_setup_additional_pages arguments Martin Schwidefsky
2008-10-15 17:45 ` [patch 2/2] introduce vdso on s390 Martin Schwidefsky
2008-10-17 15:34   ` Bastian Blank [this message]
2008-10-20 13:06     ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017153436.GA17116@wavehammer.waldi.eu.org \
    --to=bastian@waldi.eu.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --subject='Re: [patch 2/2] introduce vdso on s390' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).