LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg()
@ 2008-10-15  6:56 Lai Jiangshan
  2008-10-15 13:45 ` Mathieu Desnoyers
  0 siblings, 1 reply; 3+ messages in thread
From: Lai Jiangshan @ 2008-10-15  6:56 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Mathieu Desnoyers, Linux Kernel Mailing List


marker_probe_cb_noarg() should not be seen by outer code.
this patch remove it.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/include/linux/marker.h b/include/linux/marker.h
index 38e32e7..4aca94a 100644
--- a/include/linux/marker.h
+++ b/include/linux/marker.h
@@ -137,8 +137,6 @@ extern marker_probe_func __mark_empty_function;
 
 extern void marker_probe_cb(const struct marker *mdata,
 	void *call_private, ...);
-extern void marker_probe_cb_noarg(const struct marker *mdata,
-	void *call_private, ...);
 
 /*
  * Connect a probe to a marker.
diff --git a/kernel/marker.c b/kernel/marker.c
index ef43c86..0f2a944 100644
--- a/kernel/marker.c
+++ b/kernel/marker.c
@@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(marker_probe_cb);
  *
  * Should be connected to markers "MARK_NOARGS".
  */
-void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
+static void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
 {
 	va_list args;	/* not initialized */
 	char ptype;
@@ -197,7 +197,6 @@ void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
 	}
 	rcu_read_unlock_sched();
 }
-EXPORT_SYMBOL_GPL(marker_probe_cb_noarg);
 
 static void free_old_closure(struct rcu_head *head)
 {





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg()
  2008-10-15  6:56 [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg() Lai Jiangshan
@ 2008-10-15 13:45 ` Mathieu Desnoyers
  2008-10-20 13:30   ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Desnoyers @ 2008-10-15 13:45 UTC (permalink / raw)
  To: Lai Jiangshan; +Cc: Ingo Molnar, Linux Kernel Mailing List

* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> 
> marker_probe_cb_noarg() should not be seen by outer code.
> this patch remove it.
> 

Yep, good idea. Thanks!

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/marker.h b/include/linux/marker.h
> index 38e32e7..4aca94a 100644
> --- a/include/linux/marker.h
> +++ b/include/linux/marker.h
> @@ -137,8 +137,6 @@ extern marker_probe_func __mark_empty_function;
>  
>  extern void marker_probe_cb(const struct marker *mdata,
>  	void *call_private, ...);
> -extern void marker_probe_cb_noarg(const struct marker *mdata,
> -	void *call_private, ...);
>  
>  /*
>   * Connect a probe to a marker.
> diff --git a/kernel/marker.c b/kernel/marker.c
> index ef43c86..0f2a944 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(marker_probe_cb);
>   *
>   * Should be connected to markers "MARK_NOARGS".
>   */
> -void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
> +static void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
>  {
>  	va_list args;	/* not initialized */
>  	char ptype;
> @@ -197,7 +197,6 @@ void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...)
>  	}
>  	rcu_read_unlock_sched();
>  }
> -EXPORT_SYMBOL_GPL(marker_probe_cb_noarg);
>  
>  static void free_old_closure(struct rcu_head *head)
>  {
> 
> 
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg()
  2008-10-15 13:45 ` Mathieu Desnoyers
@ 2008-10-20 13:30   ` Ingo Molnar
  0 siblings, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-10-20 13:30 UTC (permalink / raw)
  To: Mathieu Desnoyers; +Cc: Lai Jiangshan, Linux Kernel Mailing List


* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> > 
> > marker_probe_cb_noarg() should not be seen by outer code.
> > this patch remove it.
> > 
> 
> Yep, good idea. Thanks!
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

applied to tip/tracing/markers, thanks!

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-20 13:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-15  6:56 [PATCH tip/tracing/markers] markers: remove exported symbol marker_probe_cb_noarg() Lai Jiangshan
2008-10-15 13:45 ` Mathieu Desnoyers
2008-10-20 13:30   ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).