LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joro@8bytes.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH] x86: amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE_ENTRY errors
Date: Mon, 20 Oct 2008 18:06:03 +0200	[thread overview]
Message-ID: <20081020160603.GA5744@elte.hu> (raw)
In-Reply-To: <20081016145956.GA29705@8bytes.org>


* Joerg Roedel <joro@8bytes.org> wrote:

> Argh. Very stupid bug. This explains why it worked on my system with 1G
> RAM and failed on some others with more. Thanks for the fix. I also CC
> stable@kernel.org.
> 
> On Thu, Oct 16, 2008 at 04:27:36PM +0200, Andreas Herrmann wrote:
> > We are on 64-bit so better use u64 instead of u32 to deal with
> > addresses:
> > 
> > static void __init iommu_set_device_table(struct amd_iommu *iommu)
> > {
> >         u64 entry;
> >   ...
> >         entry = virt_to_phys(amd_iommu_dev_table);
> >   ...
> > 
> > (I am wondering why gcc 4.2.x did not warn about the assignment
> > between u32 and unsigned long.)
> > 
> > Cc: iommu@lists.linux-foundation.org
> > Cc: Joerg Roedel <joerg.roedel@amd.com>
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

applied to tip/x86/urgent, thanks guys!

	Ingo

      reply	other threads:[~2008-10-20 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 14:27 Andreas Herrmann
2008-10-16 14:59 ` Joerg Roedel
2008-10-20 16:06   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081020160603.GA5744@elte.hu \
    --to=mingo@elte.hu \
    --cc=andreas.herrmann3@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86: amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE_ENTRY errors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).