LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sparc: correct section of apc_no_idle
@ 2008-10-18 16:11 Frederic Weisbecker
  2008-10-21  0:24 ` Frédéric Weisbecker
  2008-10-22  4:56 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2008-10-18 16:11 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Kernel

The latest mainline gives this section mismatch on sparc:

The function __devinit apc_probe() references
a variable __initdata apc_no_idle.
If apc_no_idle is only used by apc_probe then
annotate apc_no_idle with a matching annotation.

Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625,
apc_probe() is on __devinit so we have to correct apc_no_idle
which is referenced by this function.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c
index 4dd1ba7..9c11582 100644
--- a/arch/sparc/kernel/apc.c
+++ b/arch/sparc/kernel/apc.c
@@ -31,7 +31,7 @@
 #define APC_DEVNAME "apc"
 
 static u8 __iomem *regs;
-static int apc_no_idle __initdata = 0;
+static int apc_no_idle __devinitdata = 0;
 
 #define apc_readb(offs)		(sbus_readb(regs+offs))
 #define apc_writeb(val, offs) 	(sbus_writeb(val, regs+offs))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc: correct section of apc_no_idle
  2008-10-18 16:11 [PATCH] sparc: correct section of apc_no_idle Frederic Weisbecker
@ 2008-10-21  0:24 ` Frédéric Weisbecker
  2008-10-22  4:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Frédéric Weisbecker @ 2008-10-21  0:24 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Kernel, William L. Irwin, Sparc

2008/10/18 Frederic Weisbecker <fweisbec@gmail.com>:
> The latest mainline gives this section mismatch on sparc:
>
> The function __devinit apc_probe() references
> a variable __initdata apc_no_idle.
> If apc_no_idle is only used by apc_probe then
> annotate apc_no_idle with a matching annotation.
>
> Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625,
> apc_probe() is on __devinit so we have to correct apc_no_idle
> which is referenced by this function.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c
> index 4dd1ba7..9c11582 100644
> --- a/arch/sparc/kernel/apc.c
> +++ b/arch/sparc/kernel/apc.c
> @@ -31,7 +31,7 @@
>  #define APC_DEVNAME "apc"
>
>  static u8 __iomem *regs;
> -static int apc_no_idle __initdata = 0;
> +static int apc_no_idle __devinitdata = 0;
>
>  #define apc_readb(offs)                (sbus_readb(regs+offs))
>  #define apc_writeb(val, offs)  (sbus_writeb(val, regs+offs))
>

(Adding William and sparclinux in cc)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sparc: correct section of apc_no_idle
  2008-10-18 16:11 [PATCH] sparc: correct section of apc_no_idle Frederic Weisbecker
  2008-10-21  0:24 ` Frédéric Weisbecker
@ 2008-10-22  4:56 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2008-10-22  4:56 UTC (permalink / raw)
  To: fweisbec; +Cc: linux-kernel, sparclinux

From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Sat, 18 Oct 2008 18:11:34 +0200

[ Please post sparc patches to sparclinux@vger.kernel.org in
  the future, CC:'d ]

> The latest mainline gives this section mismatch on sparc:
> 
> The function __devinit apc_probe() references
> a variable __initdata apc_no_idle.
> If apc_no_idle is only used by apc_probe then
> annotate apc_no_idle with a matching annotation.
> 
> Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625,
> apc_probe() is on __devinit so we have to correct apc_no_idle
> which is referenced by this function.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

Applied, thanks.

> diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c
> index 4dd1ba7..9c11582 100644
> --- a/arch/sparc/kernel/apc.c
> +++ b/arch/sparc/kernel/apc.c
> @@ -31,7 +31,7 @@
>  #define APC_DEVNAME "apc"
>  
>  static u8 __iomem *regs;
> -static int apc_no_idle __initdata = 0;
> +static int apc_no_idle __devinitdata = 0;
>  
>  #define apc_readb(offs)		(sbus_readb(regs+offs))
>  #define apc_writeb(val, offs) 	(sbus_writeb(val, regs+offs))

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-22  4:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-18 16:11 [PATCH] sparc: correct section of apc_no_idle Frederic Weisbecker
2008-10-21  0:24 ` Frédéric Weisbecker
2008-10-22  4:56 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).