LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.com,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm] ftrace : Fix section mismatch warning.
Date: Wed, 22 Oct 2008 09:03:12 +0200	[thread overview]
Message-ID: <20081022070312.GA24749@elte.hu> (raw)
In-Reply-To: <20081020162756.GA31201@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Rakib Mullick <rakib.mullick@gmail.com> wrote:
> 
> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b41): Section mismatch
> > in reference from the variable ftrace_test_p6nop to the function
> > .init.text:ftrace_dyn_arch_init()
> > The function ftrace_test_p6nop() references
> > the function __init ftrace_dyn_arch_init().
> > This is often because ftrace_test_p6nop lacks a __init
> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
> > 
> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b4b): Section mismatch
> > in reference from the variable ftrace_test_nop5 to the function
> > .init.text:ftrace_dyn_arch_init()
> > The function ftrace_test_nop5() references
> > the function __init ftrace_dyn_arch_init().
> > This is often because ftrace_test_nop5 lacks a __init
> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
> > 
> > This patch fixes the above warnings. Introduced by
> > 'linux-next.patch'(2.6.27-rc5-mm1-broken-out).
> > Thanks.
> > 
> > Signed-off-by: Md.Rakib H. Mullick(rakib.mullick@gmail.com)
> 
> applied to tip/tracing/urgent, thanks!

actually, this patch is wrong: the problem highlighted in that warning 
is that ftrace_test_p6nop is non-__init while ftrace_dyn_arch_init() is 
__init. So the proper solution is to mark ftrace_test_p6nop init as 
well. (it's an assembly label so thus slightly more complex than usual, 
but doable.)

	Ingo

  reply	other threads:[~2008-10-22  7:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  5:50 Rakib Mullick
2008-10-20 16:27 ` Ingo Molnar
2008-10-22  7:03   ` Ingo Molnar [this message]
2008-10-24 11:09     ` Rakib Mullick
2008-10-24 11:50       ` Ingo Molnar
2008-10-24 12:19         ` Steven Rostedt
2008-10-24 12:22           ` Steven Rostedt
2008-10-24 13:12         ` [PATCH] ftrace: use a real variable for ftrace_nop in x86 Steven Rostedt
2008-10-24 13:17           ` Steven Rostedt
2008-10-27 15:52             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022070312.GA24749@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakib.mullick@gmail.com \
    --cc=rostedt@goodmis.com \
    --subject='Re: [PATCH -mm] ftrace : Fix section mismatch warning.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).