LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: roel kluin <roel.kluin@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make static
Date: Wed, 22 Oct 2008 11:06:42 +0100	[thread overview]
Message-ID: <20081022110642.5140c670@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <48FE6A75.5080004@gmail.com>

> Building an allnoconfig, sparse asked whether these could be static, so I checked,
> and they are only used in the file where they are declared. This means that they
> can be static, am I forgetting something? This was build and checkpatch tested.

The tty ones look correct. The tty_io one is already fixed (Jason beat
you to it). The pty one is a result of some code tidying and correct as
is the vt one. I'll merge the vt/pty bits

Alan

      parent reply	other threads:[~2008-10-22 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 23:49 roel kluin
2008-10-22  6:18 ` Ingo Molnar
2008-10-22 10:06 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022110642.5140c670@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    --subject='Re: [PATCH] Make static' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).