LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Petr Tesarik <ptesarik@suse.cz>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	tee@sgi.com, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] Allow rwlocks to re-enable interrupts
Date: Wed, 22 Oct 2008 13:05:11 -0600	[thread overview]
Message-ID: <20081022190510.GH26094@parisc-linux.org> (raw)
In-Reply-To: <1224696271.20069.8.camel@twins>

On Wed, Oct 22, 2008 at 07:24:31PM +0200, Peter Zijlstra wrote:
> > No problem. I could then also use it for _spin_lock_irqsave, if the
> > answer to the above question is use CONFIG_LOCK_STAT there as well.
> 
> If you create LOCK_CONTEDED_FLAGS() the whole issue goes away nicely.

Should it also be used for _spin_lock_irq()?  I'm puzzled why it's only
used for _irqsave().

(should _spin_lock_bh() re-enable BHs while waiting?  Is it just not big
enough of a deal?)

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2008-10-22 19:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22  8:33 [PATCH 0/2] enable irqs when waiting for rwlocks Petr Tesarik
2008-10-22  8:34 ` [PATCH 1/2] Allow rwlocks to re-enable interrupts Petr Tesarik
2008-10-22  8:45   ` Peter Zijlstra
2008-10-22  8:58     ` Petr Tesarik
2008-10-22 17:24       ` Peter Zijlstra
2008-10-22 19:05         ` Matthew Wilcox [this message]
2008-10-22 19:19           ` Peter Zijlstra
2008-10-22 17:31 ` [PATCH 0/2] enable irqs when waiting for rwlocks Rick Jones
2008-10-23 14:12   ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022190510.GH26094@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=ptesarik@suse.cz \
    --cc=tee@sgi.com \
    --subject='Re: [PATCH 1/2] Allow rwlocks to re-enable interrupts' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).