LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net> To: Andrew Morton <akpm@linux-foundation.org> Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, autofs mailing list <autofs@linux.kernel.org> Subject: [PATCH 3/6] autofs4 - collect version check return Date: Thu, 23 Oct 2008 10:35:27 +0800 [thread overview] Message-ID: <20081023023527.4508.10819.stgit@raven.themaw.net> (raw) In-Reply-To: <20081023023513.4508.54940.stgit@raven.themaw.net> The function check_dev_ioctl_version() returns an error code upon fail but it isn't captured and returned in validate_dev_ioctl() as it should be. Signed-off-by: Ian Kent <raven@themaw.net> Signed-off-by: Jeff Moyer <jmoyer@redhat.com> --- fs/autofs4/dev-ioctl.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c index 304c1ff..63bfb5d 100644 --- a/fs/autofs4/dev-ioctl.c +++ b/fs/autofs4/dev-ioctl.c @@ -116,9 +116,9 @@ static inline void free_dev_ioctl(struct autofs_dev_ioctl *param) */ static int validate_dev_ioctl(int cmd, struct autofs_dev_ioctl *param) { - int err = -EINVAL; + int err; - if (check_dev_ioctl_version(cmd, param)) { + if ((err = check_dev_ioctl_version(cmd, param))) { AUTOFS_WARN("invalid device control module version " "supplied for cmd(0x%08x)", cmd); goto out;
next prev parent reply other threads:[~2008-10-23 2:35 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-10-23 2:35 [PATCH 1/6] autofs4 - correct offset mount expire check Ian Kent 2008-10-23 2:35 ` [PATCH 2/6] autofs4 - remove string terminator check Ian Kent 2008-10-27 20:31 ` Andrew Morton 2008-10-28 0:27 ` Ian Kent 2008-10-28 0:55 ` Andrew Morton 2008-10-28 1:04 ` Ian Kent 2008-10-28 1:02 ` Ian Kent 2008-10-23 2:35 ` Ian Kent [this message] 2008-10-23 2:35 ` [PATCH 4/6] autofs4 - make autofs type usage explicit Ian Kent 2008-10-27 20:40 ` Andrew Morton 2008-10-28 0:28 ` Ian Kent 2008-10-28 13:24 ` Jeff Moyer 2008-10-23 2:35 ` [PATCH 5/6] autofs4 - improve parameter usage Ian Kent 2008-10-23 2:35 ` [PATCH 6/6] autofs4 - cleanup expire code duplication Ian Kent
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20081023023527.4508.10819.stgit@raven.themaw.net \ --to=raven@themaw.net \ --cc=akpm@linux-foundation.org \ --cc=autofs@linux.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).