LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions
@ 2008-10-22 16:06 Pekka J Enberg
  2008-10-23  9:46 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Pekka J Enberg @ 2008-10-22 16:06 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Pavel Machek, linux-kernel

From: Pekka Enberg <penberg@cs.helsinki.fi>

The functions are not used anywhere so remove them.

Cc: Pavel Machek <pavel@suse.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
 drivers/staging/winbond/linux/wbusb.c   |   19 -------------------
 drivers/staging/winbond/linux/wbusb_f.h |    2 --
 2 files changed, 0 insertions(+), 21 deletions(-)

diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
index 4b989c5..c3394bf 100644
--- a/drivers/staging/winbond/linux/wbusb.c
+++ b/drivers/staging/winbond/linux/wbusb.c
@@ -308,25 +308,6 @@ WbUsb_destroy(phw_data_t pHwData)
 {
 }
 
-int wb35_open(struct net_device *netdev)
-{
-	struct wb35_adapter * adapter = (struct wb35_adapter *)netdev->priv;
-	phw_data_t pHwData = &adapter->sHwData;
-
-        netif_start_queue(netdev);
-
-	//TODO : put here temporarily
-	hal_set_accept_broadcast(pHwData, 1); // open accept broadcast
-
-	return 0;
-}
-
-int wb35_close(struct net_device *netdev)
-{
-	netif_stop_queue(netdev);
-	return 0;
-}
-
 static void wb35_disconnect(struct usb_interface *intf)
 {
 	struct wb35_adapter * adapter = usb_get_intfdata(intf);
diff --git a/drivers/staging/winbond/linux/wbusb_f.h b/drivers/staging/winbond/linux/wbusb_f.h
index 0402f66..a1d5946 100644
--- a/drivers/staging/winbond/linux/wbusb_f.h
+++ b/drivers/staging/winbond/linux/wbusb_f.h
@@ -11,8 +11,6 @@
 //
 //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
-int wb35_open(struct net_device *netdev);
-int wb35_close(struct net_device *netdev);
 unsigned char WbUsb_initial(phw_data_t pHwData);
 void WbUsb_destroy(phw_data_t pHwData);
 unsigned char WbWLanInitialize(struct wb35_adapter *adapter);
-- 
1.5.3.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions
  2008-10-22 16:06 [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions Pekka J Enberg
@ 2008-10-23  9:46 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2008-10-23  9:46 UTC (permalink / raw)
  To: Pekka J Enberg; +Cc: Greg Kroah-Hartman, linux-kernel

On Wed 2008-10-22 19:06:13, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> The functions are not used anywhere so remove them.
> 
> Cc: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>

ACK.

> ---
>  drivers/staging/winbond/linux/wbusb.c   |   19 -------------------
>  drivers/staging/winbond/linux/wbusb_f.h |    2 --
>  2 files changed, 0 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
> index 4b989c5..c3394bf 100644
> --- a/drivers/staging/winbond/linux/wbusb.c
> +++ b/drivers/staging/winbond/linux/wbusb.c
> @@ -308,25 +308,6 @@ WbUsb_destroy(phw_data_t pHwData)
>  {
>  }
>  
> -int wb35_open(struct net_device *netdev)
> -{
> -	struct wb35_adapter * adapter = (struct wb35_adapter *)netdev->priv;
> -	phw_data_t pHwData = &adapter->sHwData;
> -
> -        netif_start_queue(netdev);
> -
> -	//TODO : put here temporarily
> -	hal_set_accept_broadcast(pHwData, 1); // open accept broadcast
> -
> -	return 0;
> -}
> -
> -int wb35_close(struct net_device *netdev)
> -{
> -	netif_stop_queue(netdev);
> -	return 0;
> -}
> -
>  static void wb35_disconnect(struct usb_interface *intf)
>  {
>  	struct wb35_adapter * adapter = usb_get_intfdata(intf);
> diff --git a/drivers/staging/winbond/linux/wbusb_f.h b/drivers/staging/winbond/linux/wbusb_f.h
> index 0402f66..a1d5946 100644
> --- a/drivers/staging/winbond/linux/wbusb_f.h
> +++ b/drivers/staging/winbond/linux/wbusb_f.h
> @@ -11,8 +11,6 @@
>  //
>  //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  
> -int wb35_open(struct net_device *netdev);
> -int wb35_close(struct net_device *netdev);
>  unsigned char WbUsb_initial(phw_data_t pHwData);
>  void WbUsb_destroy(phw_data_t pHwData);
>  unsigned char WbWLanInitialize(struct wb35_adapter *adapter);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-23  9:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-22 16:06 [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions Pekka J Enberg
2008-10-23  9:46 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).