LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [git pull] vfs patches
@ 2008-10-23  9:52 Al Viro
  0 siblings, 0 replies; 16+ messages in thread
From: Al Viro @ 2008-10-23  9:52 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Assorted VFS patches; a _lot_ is still pending (and part of the pending pile
consists of outright bug fixes).  This series at least should collect most
of the other folks' patches from the last cycle; I'd been sick
most of the last month, so there'd been a lot of delays with all that
stuff ;-/  Please, pull from
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Shortlog:
Adrian Bunk (1):
      [patch 1/3] FS_MBCACHE: don't needlessly make it built-in

Al Viro (16):
      new helper - kern_path()
      finally get rid of nameidata in namespace.c
      no need for noinline stuff in fs/namespace.c anymore
      switch quota_on-related stuff to kern_path()
      sanitize svc_export_parse()
      switch nfsd to kern_path()
      assorted path_lookup() -> kern_path() conversions
      get rid of nameidata in audit_tree
      get rid of path_lookup_create()
      don't pass bogus flags to LOOKUP_PARENT lookup in spufs
      make O_EXCL in nd->intent.flags visible in nd->flags
      reduce the stack footprint of exportfs_decode_fh()
      get rid of on-stack fake dentry in ext3_get_parent()
      get rid of on-stack dentry in ext2_get_parent()
      prepare vfs_readdir() callers to returning filldir result
      get rid of on-stack dentry in udf

Alexey Dobriyan (2):
      anondev: init IDR statically
      anondev: switch to IDA

Arjan van de Ven (1):
      fs: add a sanity check in d_free

Christoph Hellwig (9):
      dm: kill lookup_device wrapper
      hpfs: cleanup ->setattr
      tidy up chrdev_open
      generic_file_llseek tidyups
      new helper: d_obtain_alias
      switch all filesystems over to d_obtain_alias
      kill d_alloc_anon
      fix ->llseek for more directories
      reiserfs: add missing llseek method

Dan Williams (1):
      [RFC PATCH] touch_mnt_namespace when the mount flags change

David Woodhouse (6):
      Factor out nfsd_do_readdir() into its own function
      Copy XFS readdir hack into nfsd code.
      Remove XFS buffered readdir hack
      [JFFS2] Reinstate NFS exportability
      Optimise NFS readdir hack slightly.
      [JFFS2] Use d_splice_alias() not d_add() in jffs2_lookup()

Miklos Szeredi (2):
      move executable checking into ->permission()
      [patch] vfs: make security_inode_setattr() calling consistent

Mimi Zohar (1):
      i_version: remount support

OGAWA Hirofumi (6):
      vfs: replace parent == dentry->d_parent by IS_ROOT()
      vfs: add d_ancestor()
      vfs: add __d_instantiate() helper
      vfs: remove unnecessary fsnotify_d_instantiate()
      vfs: remove LOOKUP_PARENT from non LOOKUP_PARENT lookup
      vfs: add LOOKUP_RENAME_TARGET intent

Qinghuang Feng (1):
      fs/dcache.c: update comment of d_validate()


Diffstat:
 arch/alpha/kernel/osf_sys.c                  |    7 +-
 arch/parisc/hpux/fs.c                        |    5 +-
 arch/powerpc/platforms/cell/spufs/syscalls.c |    4 +-
 drivers/md/dm-table.c                        |   21 +--
 fs/Kconfig                                   |    7 +-
 fs/afs/dir.c                                 |    1 +
 fs/attr.c                                    |   10 +-
 fs/bfs/dir.c                                 |    1 +
 fs/block_dev.c                               |   14 +-
 fs/char_dev.c                                |   21 ++-
 fs/cifs/cifsfs.c                             |   10 +-
 fs/coda/dir.c                                |    3 +
 fs/coda/pioctl.c                             |    2 +-
 fs/compat.c                                  |   22 +--
 fs/configfs/symlink.c                        |   16 +-
 fs/dcache.c                                  |  184 +++++++++++++-------------
 fs/dquot.c                                   |   10 +-
 fs/ecryptfs/main.c                           |   23 ++--
 fs/efs/namei.c                               |   29 +----
 fs/exportfs/expfs.c                          |   20 +--
 fs/ext2/dir.c                                |   14 +-
 fs/ext2/ext2.h                               |    4 +-
 fs/ext2/namei.c                              |   30 +----
 fs/ext3/namei.c                              |   84 +++++-------
 fs/ext3/super.c                              |   22 ++--
 fs/ext4/namei.c                              |   11 +--
 fs/ext4/super.c                              |   24 ++--
 fs/fat/dir.c                                 |    1 +
 fs/fat/inode.c                               |   52 +++-----
 fs/fuse/inode.c                              |   23 +--
 fs/gfs2/ops_export.c                         |   33 ++----
 fs/gfs2/ops_inode.c                          |    2 +-
 fs/hfs/inode.c                               |    8 -
 fs/hfsplus/inode.c                           |   13 --
 fs/hpfs/file.c                               |    2 +-
 fs/hpfs/hpfs_fn.h                            |    2 +-
 fs/hpfs/inode.c                              |   29 +++--
 fs/hpfs/namei.c                              |    2 +-
 fs/isofs/export.c                            |   33 +----
 fs/jffs2/dir.c                               |    7 +-
 fs/jffs2/super.c                             |   48 +++++++
 fs/jfs/namei.c                               |   16 +--
 fs/libfs.c                                   |   26 +----
 fs/namei.c                                   |  146 ++++++++++-----------
 fs/namespace.c                               |  133 +++++++++----------
 fs/nfs/dir.c                                 |    9 +-
 fs/nfs/getroot.c                             |   14 +-
 fs/nfsd/export.c                             |  125 ++++++++----------
 fs/nfsd/nfs4recover.c                        |   50 ++++----
 fs/nfsd/nfs4state.c                          |    8 +-
 fs/nfsd/nfsctl.c                             |    8 +-
 fs/nfsd/vfs.c                                |  126 +++++++++++++++---
 fs/ntfs/namei.c                              |   22 +---
 fs/ocfs2/export.c                            |   30 +----
 fs/omfs/dir.c                                |    1 +
 fs/openpromfs/inode.c                        |    1 +
 fs/proc/proc_sysctl.c                        |   11 ++-
 fs/read_write.c                              |   58 ++++++---
 fs/readdir.c                                 |   22 +--
 fs/reiserfs/file.c                           |    1 +
 fs/reiserfs/inode.c                          |   13 +--
 fs/reiserfs/namei.c                          |   11 +--
 fs/reiserfs/super.c                          |   18 ++--
 fs/super.c                                   |   15 +--
 fs/sysfs/dir.c                               |    1 +
 fs/udf/namei.c                               |   43 ++----
 fs/ufs/dir.c                                 |    1 +
 fs/xfs/linux-2.6/xfs_export.c                |   32 +----
 fs/xfs/linux-2.6/xfs_file.c                  |  128 ------------------
 fs/xfs/linux-2.6/xfs_ioctl.c                 |    7 +-
 include/linux/dcache.h                       |    3 +-
 include/linux/fs.h                           |    8 +-
 include/linux/namei.h                        |    8 +-
 init/main.c                                  |    1 -
 kernel/audit_tree.c                          |   48 ++++----
 net/unix/af_unix.c                           |   18 ++-
 76 files changed, 883 insertions(+), 1133 deletions(-)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] vfs patches
  2008-08-03 14:08 ` Roland Dreier
@ 2008-08-03 14:53   ` Al Viro
  0 siblings, 0 replies; 16+ messages in thread
From: Al Viro @ 2008-08-03 14:53 UTC (permalink / raw)
  To: Roland Dreier; +Cc: Linus Torvalds, linux-kernel

On Sun, Aug 03, 2008 at 07:08:42AM -0700, Roland Dreier wrote:
> Something seems a little strange about your git worflow, with patch
> descriptions such as
> 
>  >       [patch 3/4] vfs: remove unused nameidata argument of may_create()
> 
> making it in without the "[patch 3/4]" part being stripped, and even
> worse descriptions such as
> 
>  >       Re: BUG at security/selinux/avc.c:883 (was: Re: linux-next: Tree
> 
> getting committed too....

git-am -k ...  FWIW, I tend to leave [patch...] alone; the second one slipped
unnoticed - usually I edit ones like that, including the subject.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] vfs patches
  2008-08-01 15:36 Al Viro
@ 2008-08-03 14:08 ` Roland Dreier
  2008-08-03 14:53   ` Al Viro
  0 siblings, 1 reply; 16+ messages in thread
From: Roland Dreier @ 2008-08-03 14:08 UTC (permalink / raw)
  To: Al Viro; +Cc: Linus Torvalds, linux-kernel

Something seems a little strange about your git worflow, with patch
descriptions such as

 >       [patch 3/4] vfs: remove unused nameidata argument of may_create()

making it in without the "[patch 3/4]" part being stripped, and even
worse descriptions such as

 >       Re: BUG at security/selinux/avc.c:883 (was: Re: linux-next: Tree

getting committed too....

 - R.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [git pull] vfs patches
@ 2008-08-01 15:36 Al Viro
  2008-08-03 14:08 ` Roland Dreier
  0 siblings, 1 reply; 16+ messages in thread
From: Al Viro @ 2008-08-01 15:36 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Assorted fixes, better dup2() atomicity, more nameidata eviction, Alexey's
sanitizing of procfs inumbers and of IDR use in fs/*/* in general.  Please,
pull from

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Shortlog:
Al Viro (7):
      ipv4_static_sysctl_init() should be under CONFIG_SYSCTL
      merge locate_fd() and get_unused_fd()
      clean dup2() up a bit
      fix races and leaks in vfs_quota_on() users
      fix bdev leak in block_dev.c do_open()
      switch mtd and dm-table to lookup_bdev()
      pass struct path * to do_add_mount()

Alexey Dobriyan (3):
      proc: fix inode number bogorithmetic
      proc: switch inode number allocation to IDA
      devpts: switch to IDA

Miklos Szeredi (1):
      [patch 3/4] vfs: remove unused nameidata argument of may_create()

Stephen Smalley (1):
      Re: BUG at security/selinux/avc.c:883 (was: Re: linux-next: Tree

Diffstat:
 drivers/md/dm-table.c    |   29 ++--------
 drivers/mtd/mtdsuper.c   |   33 ++++-------
 fs/afs/mntpt.c           |    2 +-
 fs/block_dev.c           |    5 +-
 fs/cifs/cifs_dfs_ref.c   |    2 +-
 fs/devpts/inode.c        |   16 +++---
 fs/dquot.c               |   33 +++++++----
 fs/ext3/super.c          |    3 +-
 fs/ext4/super.c          |    3 +-
 fs/fcntl.c               |  140 +++++++++++++--------------------------------
 fs/file.c                |   61 ++++++++++++++++++++
 fs/namei.c               |   17 +++---
 fs/namespace.c           |   16 +++---
 fs/nfs/namespace.c       |    2 +-
 fs/open.c                |   56 ------------------
 fs/proc/generic.c        |   27 ++++-----
 fs/reiserfs/super.c      |   16 +++--
 include/linux/file.h     |    3 +-
 include/linux/mount.h    |    3 +-
 include/linux/quotaops.h |    2 +
 net/ipv4/route.c         |    2 +
 21 files changed, 203 insertions(+), 268 deletions(-)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [git pull] vfs patches
@ 2008-06-25  3:32 Al Viro
  0 siblings, 0 replies; 16+ messages in thread
From: Al Viro @ 2008-06-25  3:32 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

	Misc fixes + several obvious cleanups + dcache.c locking annotation
fixes.  Please, pull from
git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Diffstat:
 fs/block_dev.c         |   12 +++++++-
 fs/dcache.c            |   68 ++++++++++++++++++++++++------------------------
 fs/locks.c             |    6 ----
 fs/namei.c             |   26 +++++++++---------
 fs/pipe.c              |   10 +++----
 fs/utimes.c            |   59 +++++++++++++++++++----------------------
 include/linux/dcache.h |    2 +-
 include/linux/fs.h     |    2 -
 8 files changed, 90 insertions(+), 95 deletions(-)

Shortlog:
Al Viro (1):
      fix cgroup-inflicted breakage in block_dev.c

Andreas Gruenbacher (1):
      [patch 3/3] vfs: make d_path() consistent across mount operations

Denis V. Lunev (1):
      [patch 4/4] flock: remove unused fields from file_lock_operations

Jan Blunck (1):
      [patch 1/4] vfs: path_{get,put}() cleanups

Jan Engelhardt (1):
      [patch 2/4] fs: make struct file arg to d_path const

Marcin Slusarz (1):
      [patch 3/4] vfs: fix ERR_PTR abuse in generic_readlink

Michael Kerrisk (4):
      [patch for 2.6.26 2/4] vfs: utimensat(): be consistent with utime() for immutable and append-only files
      [patch for 2.6.26 1/4] vfs: utimensat(): ignore tv_sec if tv_nsec == UTIME_OMIT or UTIME_NOW
      [patch for 2.6.26 3/4] vfs: utimensat(): fix error checking for {UTIME_NOW,UTIME_OMIT} case
      [patch for 2.6.26 4/4] vfs: utimensat(): fix write access check for futimens()

Miklos Szeredi (2):
      [patch 1/3] vfs: dcache sparse fixes
      [patch 2/3] vfs: dcache cleanups

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches 
  2008-04-26  2:02 [git pull] VFS patches Al Viro
  2008-04-26 11:01 ` Ingo Molnar
@ 2008-05-20 12:04 ` hooanon05
  1 sibling, 0 replies; 16+ messages in thread
From: hooanon05 @ 2008-05-20 12:04 UTC (permalink / raw)
  To: Al Viro; +Cc: Linus Torvalds, linux-kernel, linux-fsdevel


Hello Al,

I have a question about the commit you made last month.
When an application issues sys_oldumount(), ->umount_begin() will not be
called because the flag is 0. Is this behaviour intended?
And it it better to put the paranthesis around (flags & MNT_FORCE).


Junjiro Okajima


Al Viro:
> 	Tonight's pile: getting ->umount_begin() back to sanity, race fixes
> around execve(), general cleanups.  Please, pull from
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus
> 
> Shortlog:
> 
> Al Viro (5):
>       restore sane ->umount_begin() API
	:::
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 0505fb6..f48f981 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1061,10 +1061,11 @@ static int do_umount(struct vfsmount *mnt, int flags)
>  	 * about for the moment.
>  	 */
>  
> -	lock_kernel();
> -	if (sb->s_op->umount_begin)
> -		sb->s_op->umount_begin(mnt, flags);
> -	unlock_kernel();
> +	if (flags & MNT_FORCE && sb->s_op->umount_begin) {
> +		lock_kernel();
> +		sb->s_op->umount_begin(sb);
> +		unlock_kernel();
> +	}
>  
>  	/*
>  	 * No sense to grab the lock for this test, but test itself looks

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [git pull] vfs patches
@ 2008-05-17  7:19 Al Viro
  0 siblings, 0 replies; 16+ messages in thread
From: Al Viro @ 2008-05-17  7:19 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

	Misc VFS fixes.  Please, pull from 
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Summary:
Al Viro (8):
      take init_files to fs/file.c
      dup_fd() fixes, part 1
      dup_fd() part 2
      dup_fd() - part 3
      dup_fd() part 4 - race fix
      avoid multiplication overflows and signedness issues for max_fds
      get rid of leak in compat_execve()
      return to old errno choice in mkdir() et.al.

WANG Cong (2):
      [Patch] fs/binfmt_elf.c: fix a wrong free
      [Patch] fs/binfmt_elf.c: fix wrong return values

Diffstat:
 arch/alpha/kernel/init_task.c     |    1 -
 arch/arm/kernel/init_task.c       |    1 -
 arch/avr32/kernel/init_task.c     |    1 -
 arch/blackfin/kernel/init_task.c  |    1 -
 arch/cris/kernel/process.c        |    1 -
 arch/frv/kernel/init_task.c       |    1 -
 arch/h8300/kernel/init_task.c     |    1 -
 arch/ia64/kernel/init_task.c      |    1 -
 arch/m32r/kernel/init_task.c      |    1 -
 arch/m68k/kernel/process.c        |    1 -
 arch/m68knommu/kernel/init_task.c |    1 -
 arch/mips/kernel/init_task.c      |    1 -
 arch/mn10300/kernel/init_task.c   |    1 -
 arch/parisc/kernel/init_task.c    |    1 -
 arch/powerpc/kernel/init_task.c   |    1 -
 arch/s390/kernel/init_task.c      |    1 -
 arch/sh/kernel/init_task.c        |    1 -
 arch/sparc/kernel/init_task.c     |    1 -
 arch/sparc64/kernel/init_task.c   |    1 -
 arch/um/kernel/init_task.c        |    1 -
 arch/v850/kernel/init_task.c      |    1 -
 arch/x86/kernel/init_task.c       |    1 -
 arch/xtensa/kernel/init_task.c    |    1 -
 fs/binfmt_elf.c                   |    9 +-
 fs/compat.c                       |    4 +-
 fs/exec.c                         |   12 ++-
 fs/file.c                         |  152 ++++++++++++++++++++++++++++++++++++-
 fs/namei.c                        |   12 ++-
 include/linux/binfmts.h           |    1 +
 include/linux/fdtable.h           |    1 +
 include/linux/init_task.h         |   23 +------
 kernel/fork.c                     |  130 -------------------------------
 kernel/sysctl.c                   |    5 +-
 33 files changed, 180 insertions(+), 192 deletions(-)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches
  2008-04-26 13:35   ` Matthew Wilcox
  2008-04-26 13:44     ` Ingo Molnar
@ 2008-04-26 19:02     ` Mike Galbraith
  1 sibling, 0 replies; 16+ messages in thread
From: Mike Galbraith @ 2008-04-26 19:02 UTC (permalink / raw)
  To: Matthew Wilcox
  Cc: Ingo Molnar, Al Viro, Linus Torvalds, linux-kernel, linux-fsdevel


On Sat, 2008-04-26 at 07:35 -0600, Matthew Wilcox wrote:
> On Sat, Apr 26, 2008 at 01:01:39PM +0200, Ingo Molnar wrote:
> > 
> > * Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > 
> > >      sanitize unshare_files/reset_files_struct
> > 
> > today's -git started crashing on me in randconfig boot tests:
> > 
> > [    0.124077] BUG: unable to handle kernel NULL pointer dereference at 00000296
> > [    0.126981] IP: [<c01217fb>] put_files_struct+0xb/0xa0
> > [    0.128981] *pdpt = 0000000000f73001 *pde = 0000000000000000
> > [    0.131231] Oops: 0002 [#1] PREEMPT
> 
> Did you have http://lkml.org/lkml/2008/4/26/1 applied?

(Al: fixed my crash report as well)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches
  2008-04-26 13:44     ` Ingo Molnar
@ 2008-04-26 15:43       ` Ingo Molnar
  0 siblings, 0 replies; 16+ messages in thread
From: Ingo Molnar @ 2008-04-26 15:43 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: Al Viro, Linus Torvalds, linux-kernel, linux-fsdevel


* Ingo Molnar <mingo@elte.hu> wrote:

> > Did you have http://lkml.org/lkml/2008/4/26/1 applied?
> 
> not yet - will try that. (but i suspect it will fix it)

yep, that did the trick - thanks.

	Ingo

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches
  2008-04-26 13:35   ` Matthew Wilcox
@ 2008-04-26 13:44     ` Ingo Molnar
  2008-04-26 15:43       ` Ingo Molnar
  2008-04-26 19:02     ` Mike Galbraith
  1 sibling, 1 reply; 16+ messages in thread
From: Ingo Molnar @ 2008-04-26 13:44 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: Al Viro, Linus Torvalds, linux-kernel, linux-fsdevel


* Matthew Wilcox <matthew@wil.cx> wrote:

> On Sat, Apr 26, 2008 at 01:01:39PM +0200, Ingo Molnar wrote:
> > 
> > * Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > 
> > >      sanitize unshare_files/reset_files_struct
> > 
> > today's -git started crashing on me in randconfig boot tests:
> > 
> > [    0.124077] BUG: unable to handle kernel NULL pointer dereference at 00000296
> > [    0.126981] IP: [<c01217fb>] put_files_struct+0xb/0xa0
> > [    0.128981] *pdpt = 0000000000f73001 *pde = 0000000000000000
> > [    0.131231] Oops: 0002 [#1] PREEMPT
> 
> Did you have http://lkml.org/lkml/2008/4/26/1 applied?

not yet - will try that. (but i suspect it will fix it)

	Ingo

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches
  2008-04-26 11:01 ` Ingo Molnar
@ 2008-04-26 13:35   ` Matthew Wilcox
  2008-04-26 13:44     ` Ingo Molnar
  2008-04-26 19:02     ` Mike Galbraith
  0 siblings, 2 replies; 16+ messages in thread
From: Matthew Wilcox @ 2008-04-26 13:35 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Al Viro, Linus Torvalds, linux-kernel, linux-fsdevel

On Sat, Apr 26, 2008 at 01:01:39PM +0200, Ingo Molnar wrote:
> 
> * Al Viro <viro@ZenIV.linux.org.uk> wrote:
> 
> >      sanitize unshare_files/reset_files_struct
> 
> today's -git started crashing on me in randconfig boot tests:
> 
> [    0.124077] BUG: unable to handle kernel NULL pointer dereference at 00000296
> [    0.126981] IP: [<c01217fb>] put_files_struct+0xb/0xa0
> [    0.128981] *pdpt = 0000000000f73001 *pde = 0000000000000000
> [    0.131231] Oops: 0002 [#1] PREEMPT

Did you have http://lkml.org/lkml/2008/4/26/1 applied?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] VFS patches
  2008-04-26  2:02 [git pull] VFS patches Al Viro
@ 2008-04-26 11:01 ` Ingo Molnar
  2008-04-26 13:35   ` Matthew Wilcox
  2008-05-20 12:04 ` hooanon05
  1 sibling, 1 reply; 16+ messages in thread
From: Ingo Molnar @ 2008-04-26 11:01 UTC (permalink / raw)
  To: Al Viro; +Cc: Linus Torvalds, linux-kernel, linux-fsdevel


* Al Viro <viro@ZenIV.linux.org.uk> wrote:

>      sanitize unshare_files/reset_files_struct

today's -git started crashing on me in randconfig boot tests:

[    0.124077] BUG: unable to handle kernel NULL pointer dereference at 00000296
[    0.126981] IP: [<c01217fb>] put_files_struct+0xb/0xa0
[    0.128981] *pdpt = 0000000000f73001 *pde = 0000000000000000
[    0.131231] Oops: 0002 [#1] PREEMPT

crash log and config at:

  http://redhat.com/~mingo/misc/log-Sat_Apr_26_11_20_58_CEST_2008.bad
  http://redhat.com/~mingo/misc/config-Sat_Apr_26_11_20_58_CEST_2008.bad

bisected it down to:

| 3b1253880b7a9e6db54b943b2d40bcf2202f58ab is first bad commit
| commit 3b1253880b7a9e6db54b943b2d40bcf2202f58ab
| Author: Al Viro <viro@zeniv.linux.org.uk>
| Date:   Tue Apr 22 05:31:30 2008 -0400
|
|     [PATCH] sanitize unshare_files/reset_files_struct

find the git-bisect log output below.

	Ingo

----------------->
git-bisect start
# bad: [b1721d0da266b4af8cb4419473b4ca36206ab200] v4l/dvb: add statics to avoid multiple definitions
git-bisect bad b1721d0da266b4af8cb4419473b4ca36206ab200
# bad: [cf2ec150fc5f59dbf2260863225c79aa0cfc46af] Merge branch 'for-linus' of git://linux-nfs.org/~bfields/linux
git-bisect bad cf2ec150fc5f59dbf2260863225c79aa0cfc46af
# good: [cf2ec150fc5f59dbf2260863225c79aa0cfc46af] Merge branch 'for-linus' of git://linux-nfs.org/~bfields/linux
git-bisect good cf2ec150fc5f59dbf2260863225c79aa0cfc46af
# good: [cf2ec150fc5f59dbf2260863225c79aa0cfc46af] Merge branch 'for-linus' of git://linux-nfs.org/~bfields/linux
git-bisect good cf2ec150fc5f59dbf2260863225c79aa0cfc46af
# bad: [b1721d0da266b4af8cb4419473b4ca36206ab200] v4l/dvb: add statics to avoid multiple definitions
git-bisect bad b1721d0da266b4af8cb4419473b4ca36206ab200
# good: [ad5e1b0f5d913d2c8bddfba81049cc07228da1a6] Merge git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild
git-bisect good ad5e1b0f5d913d2c8bddfba81049cc07228da1a6
# good: [4953d141dc5db748475001cfbfdcc42e66cf900e] usb: don't update devnum for wusb devices
git-bisect good 4953d141dc5db748475001cfbfdcc42e66cf900e
# good: [bf16ae250999e76aff0491a362073a552db965fc] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86-pat
git-bisect good bf16ae250999e76aff0491a362073a552db965fc
# good: [6ec859e1b21ab42bfc36bb3b51db275480165c8a] [POWERPC] celleb: Consolidate io-workarounds code
git-bisect good 6ec859e1b21ab42bfc36bb3b51db275480165c8a
# good: [f360bf0015e5b3e82be61c68e0863b3f98852ee2] [POWERPC] Add zImage.iseries to arch/powerpc/boot/.gitignore
git-bisect good f360bf0015e5b3e82be61c68e0863b3f98852ee2
# good: [6e18933f2b6156d0a0ec9d5522ab6a6033cf7241] Merge branch 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6
git-bisect good 6e18933f2b6156d0a0ec9d5522ab6a6033cf7241
# bad: [f8f95702f0c4529b0f59488f4509608f0c160e77] sanitize locate_fd()
git-bisect bad f8f95702f0c4529b0f59488f4509608f0c160e77
# good: [6b335d9c80d7f3c2a3f6545f664ae9007a0f3821] close race in unshare_files()
git-bisect good 6b335d9c80d7f3c2a3f6545f664ae9007a0f3821
# bad: [3b1253880b7a9e6db54b943b2d40bcf2202f58ab] sanitize unshare_files/reset_files_struct
git-bisect bad 3b1253880b7a9e6db54b943b2d40bcf2202f58ab
# good: [fd8328be874f4190a811c58cd4778ec2c74d2c05] sanitize handling of shared descriptor tables in failing execve()
git-bisect good fd8328be874f4190a811c58cd4778ec2c74d2c05


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [git pull] VFS patches
@ 2008-04-26  2:02 Al Viro
  2008-04-26 11:01 ` Ingo Molnar
  2008-05-20 12:04 ` hooanon05
  0 siblings, 2 replies; 16+ messages in thread
From: Al Viro @ 2008-04-26  2:02 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-fsdevel

	Tonight's pile: getting ->umount_begin() back to sanity, race fixes
around execve(), general cleanups.  Please, pull from

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Shortlog:

Al Viro (5):
      restore sane ->umount_begin() API
      close race in unshare_files()
      sanitize handling of shared descriptor tables in failing execve()
      sanitize unshare_files/reset_files_struct
      sanitize locate_fd()

Igor Mammedov (1):
      cifs: timeout dfs automounts +little fix.

Diffstat:

 fs/9p/vfs_super.c      |    7 ++---
 fs/binfmt_elf.c        |   23 +------------------
 fs/binfmt_misc.c       |   18 +--------------
 fs/binfmt_som.c        |   10 --------
 fs/cifs/cifs_dfs_ref.c |   29 +++++++++++++++++------
 fs/cifs/cifsfs.c       |   10 ++-----
 fs/cifs/cifsproto.h    |    8 +-----
 fs/exec.c              |   28 ++++++++++-------------
 fs/fcntl.c             |   40 +++++++++++---------------------
 fs/fuse/inode.c        |    5 +--
 fs/namespace.c         |    9 ++++---
 fs/nfs/super.c         |    8 ++----
 include/linux/file.h   |    3 +-
 include/linux/fs.h     |    5 +---
 kernel/exit.c          |    6 +---
 kernel/fork.c          |   58 +++++++++++++++++++----------------------------
 16 files changed, 95 insertions(+), 172 deletions(-)


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] vfs patches
  2008-03-25 16:05 ` Linus Torvalds
@ 2008-03-25 18:00   ` Al Viro
  0 siblings, 0 replies; 16+ messages in thread
From: Al Viro @ 2008-03-25 18:00 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

On Tue, Mar 25, 2008 at 09:05:59AM -0700, Linus Torvalds wrote:

> 	dget(save.dentry);
> 	mntget(save.mnt);
> 	...
> 	path_put(&save);
> 
> which looks very strange compared to the natural sequence:
> 
> 	path_get(&save);
> 	..
> 	path_put(&save);
> 
> and yes, I realize the code was just moved (and the reason for the mixing 
> is that the "path_put()" conversion was done much more aggressively, as 
> the ordering matters), but I'm bringing this up in the hope somebody has 
> the energy to clean things like up some day...

*nod*

Keep in mind that there's a lot more coming post-.25; FWIW, there's another
bunch of patches that probably ought to go before .25 (mount expiry stuff;
I'll do a bit of reordering and probably ask to pull tomorrow).

The next couple of cycles is going to get interesting around
fs/{namei,namespace,pnode,super,dentry}.c

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [git pull] vfs patches
  2008-03-25  8:17 [git pull] vfs patches Al Viro
@ 2008-03-25 16:05 ` Linus Torvalds
  2008-03-25 18:00   ` Al Viro
  0 siblings, 1 reply; 16+ messages in thread
From: Linus Torvalds @ 2008-03-25 16:05 UTC (permalink / raw)
  To: Al Viro; +Cc: linux-kernel



On Tue, 25 Mar 2008, Al Viro wrote:
>
> misc VFS fixes for 2.6.25.  Please pull from
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Pulled.

And looking at the diffs, I see sequences like

	dget(save.dentry);
	mntget(save.mnt);
	...
	path_put(&save);

which looks very strange compared to the natural sequence:

	path_get(&save);
	..
	path_put(&save);

and yes, I realize the code was just moved (and the reason for the mixing 
is that the "path_put()" conversion was done much more aggressively, as 
the ordering matters), but I'm bringing this up in the hope somebody has 
the energy to clean things like up some day...

			Linus

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [git pull] vfs patches
@ 2008-03-25  8:17 Al Viro
  2008-03-25 16:05 ` Linus Torvalds
  0 siblings, 1 reply; 16+ messages in thread
From: Al Viro @ 2008-03-25  8:17 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

misc VFS fixes for 2.6.25.  Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus

Shortlog:
Al Viro (5):
      restore export of do_kern_mount()
      sanitize hppfs
      double dput() on failure exit in tiny-shmem
      double iput() on failure exit in hugetlb
      get stack footprint of pathname resolution back to relative sanity

Christoph Hellwig (1):
      check for null vfsmount in dentry_open()

Dave Hansen (2):
      hppfs pass vfsmount to dentry_open()
      fix up new filp allocators

Jeff Mahoney (1):
      reiserfs: eliminate private use of struct file in xattr

Diffstat:
 fs/anon_inodes.c      |   18 +-
 fs/file_table.c       |    6 +
 fs/hppfs/hppfs_kern.c |  435 +++++++++++++++++++++++--------------------------
 fs/hugetlbfs/inode.c  |    2 +-
 fs/namei.c            |   63 ++++----
 fs/open.c             |   12 ++
 fs/pipe.c             |   19 +-
 fs/reiserfs/xattr.c   |  110 ++++---------
 fs/super.c            |    1 +
 mm/tiny-shmem.c       |    2 +
 10 files changed, 302 insertions(+), 366 deletions(-)


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2008-10-23  9:52 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-23  9:52 [git pull] vfs patches Al Viro
  -- strict thread matches above, loose matches on Subject: below --
2008-08-01 15:36 Al Viro
2008-08-03 14:08 ` Roland Dreier
2008-08-03 14:53   ` Al Viro
2008-06-25  3:32 Al Viro
2008-05-17  7:19 Al Viro
2008-04-26  2:02 [git pull] VFS patches Al Viro
2008-04-26 11:01 ` Ingo Molnar
2008-04-26 13:35   ` Matthew Wilcox
2008-04-26 13:44     ` Ingo Molnar
2008-04-26 15:43       ` Ingo Molnar
2008-04-26 19:02     ` Mike Galbraith
2008-05-20 12:04 ` hooanon05
2008-03-25  8:17 [git pull] vfs patches Al Viro
2008-03-25 16:05 ` Linus Torvalds
2008-03-25 18:00   ` Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).