LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Robert Hancock <hancockr@shaw.ca>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Maciej Rutecki <maciej.rutecki@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org, lenb@kernel.org,
	fabio.comolli@gmail.com
Subject: Re: [Re: Linux 2.6.28-rc1] ACPI Warning (nspredef-0852)[...]
Date: Sat, 25 Oct 2008 20:04:00 +0200	[thread overview]
Message-ID: <200810252004.01274.rjw@sisk.pl> (raw)
In-Reply-To: <49035313.9080309@shaw.ca>

On Saturday, 25 of October 2008, Robert Hancock wrote:
> Henrique de Moraes Holschuh wrote:
> > On Sat, 25 Oct 2008, Rafael J. Wysocki wrote:
> >> On Saturday, 25 of October 2008, Maciej Rutecki wrote:
> >>> During suspend to ram I have this message:
> >>>
> >>> ACPI Warning (nspredef-0852): \_WAK: Return type mismatch - found
> >>> Integer, expected Package [20080926]
> >>>
> >>> s2ram seems works OK
> >>>
> >>> dmesg, acpidump:
> >>> http://unixy.pl/maciek/download/kernel/2.6.28-rc1_wak/
> >> IMO it's yet another incarnation of
> >> http://bugzilla.kernel.org/show_bug.cgi?id=11822
> > 
> > If this is an outright violation of the ACPI spec, let me know (and if
> > possible, please tell me the spec page).  This is the kind of thing I expect
> > it would be a no-brainer to get Lenovo to fix with a BIOS update.
> 
> I don't think this is the same issue, but in both cases it looks like 
> the BIOS AML code is wrong (just judging from the output, haven't looked 
> at the dump yet). _WAK is supposed to return a package of 2 DWORD 
> values, a bit field of conditions that occurred during sleep, and the 
> effective S-state the system actually entered (section 7.3.7 of the ACPI 
> 3.0 spec). Presumably the BIOS is returning a single integer.

The underlying issue is we've never reported such BIOS bugs before and now we
do that unconditionally.  IMnshO, this should only be done if ACPI debugging is
enabled.

While I can see a value in doing that always, IMO such a change should only be
made after a big announcement.

Thanks,
Rafael

  reply	other threads:[~2008-10-25 17:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.1HaqObZirROiyqr922A7hRDVc54@ifi.uio.no>
     [not found] ` <fa.SvX6X2rOJRj5l1wwqyz6iNq7qHU@ifi.uio.no>
     [not found]   ` <fa.Rzh43vSl9NX1QQ2nOYQSgEJcZAw@ifi.uio.no>
2008-10-25 17:10     ` Robert Hancock
2008-10-25 18:04       ` Rafael J. Wysocki [this message]
2008-10-25 18:51         ` Maciej Rutecki
2008-10-27 20:19           ` Maciej Rutecki
2008-10-28  7:18             ` Zhao Yakui
2008-10-28  9:44             ` Zhao Yakui
2008-10-28 19:45               ` Maciej Rutecki
2008-11-03 12:06                 ` Maciej Rutecki
2008-11-03 12:26                   ` Alexey Starikovskiy
2008-11-03 14:17                     ` Alan Jenkins
2008-11-03 16:37                     ` Maciej Rutecki
2008-11-03 19:01                       ` Maciej Rutecki
2008-11-03 19:41                         ` Maciej Rutecki
2008-11-30  5:03         ` [Re: " Len Brown
2008-10-25  7:21 Maciej Rutecki
2008-10-25 10:59 ` Rafael J. Wysocki
2008-10-25 11:43   ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810252004.01274.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=fabio.comolli@gmail.com \
    --cc=hancockr@shaw.ca \
    --cc=hmh@hmh.eng.br \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    --subject='Re: [Re: Linux 2.6.28-rc1] ACPI Warning (nspredef-0852)[...]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).