LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.28-rc2] x86_64: remove duplicated register setup code in ia32 signal delivery
@ 2008-10-27 8:30 Mikael Pettersson
2008-10-27 9:44 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2008-10-27 8:30 UTC (permalink / raw)
To: mingo; +Cc: hpa, linux-kernel, tglx
ia32_setup_rt_frame() has a duplicated code block labelled
"Make -mregparm=3 work" for setting up the register parameters
to the user-mode signal handler.
This is harmless but ugly. Remove the redundant assignments.
Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
---
arch/x86/ia32/ia32_signal.c | 5 -----
1 file changed, 5 deletions(-)
diff -rupN linux-2.6.28-rc2/arch/x86/ia32/ia32_signal.c linux-2.6.28-rc2.x86-signals-fixes/arch/x86/ia32/ia32_signal.c
--- linux-2.6.28-rc2/arch/x86/ia32/ia32_signal.c 2008-10-26 21:35:33.000000000 +0100
+++ linux-2.6.28-rc2.x86-signals-fixes/arch/x86/ia32/ia32_signal.c 2008-10-27 08:14:43.000000000 +0100
@@ -572,11 +572,6 @@ int ia32_setup_rt_frame(int sig, struct
regs->dx = (unsigned long) &frame->info;
regs->cx = (unsigned long) &frame->uc;
- /* Make -mregparm=3 work */
- regs->ax = sig;
- regs->dx = (unsigned long) &frame->info;
- regs->cx = (unsigned long) &frame->uc;
-
loadsegment(ds, __USER32_DS);
loadsegment(es, __USER32_DS);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.28-rc2] x86_64: remove duplicated register setup code in ia32 signal delivery
2008-10-27 8:30 [PATCH 2.6.28-rc2] x86_64: remove duplicated register setup code in ia32 signal delivery Mikael Pettersson
@ 2008-10-27 9:44 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-27 9:44 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: mingo, hpa, linux-kernel, tglx
* Mikael Pettersson <mikpe@it.uu.se> wrote:
> ia32_setup_rt_frame() has a duplicated code block labelled
> "Make -mregparm=3 work" for setting up the register parameters
> to the user-mode signal handler.
>
> This is harmless but ugly. Remove the redundant assignments.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
> arch/x86/ia32/ia32_signal.c | 5 -----
> 1 file changed, 5 deletions(-)
applied to tip/x86/cleanups, thanks Mikael!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-27 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-27 8:30 [PATCH 2.6.28-rc2] x86_64: remove duplicated register setup code in ia32 signal delivery Mikael Pettersson
2008-10-27 9:44 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).