LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timers: Handle HRTIMER_CB_IRQSAFE_UNLOCKED correctly from softirq context
Date: Mon, 27 Oct 2008 14:21:59 +0100	[thread overview]
Message-ID: <20081027132159.GF25371@elte.hu> (raw)
In-Reply-To: <20081025142325.GB8446@linux.vnet.ibm.com>


* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> > > > Fix this by emulating hardirq context while running these callbacks from
> > > > the hrtimer softirq.
> > > 
> > > Good catch!!!  One confusion (probably on my part) below.
> > 
> > Hmm.. Let's see...
> 
> Gah!!!
> 
> I am so used to seeing sequences of code that disable irqs and then 
> re-enable them that I misread the original, failing to see that you 
> were -enabling- irqs and then re-disabling them.  :-/
> 
> Never mind!!!  Sorry for the noise...

ok - i've applied Gautham's fix to tip/timers/urgent, with your and 
Peter's Acked-by lines.

	Ingo

      reply	other threads:[~2008-10-27 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23 21:50 [PATCH] timers: Handle HRTIMER_CB_IRQSAFE_UNLOCKED correctly from softirq context Gautham R Shenoy
2008-10-23 21:58 ` Peter Zijlstra
2008-10-25  2:33 ` Paul E. McKenney
2008-10-25  4:52   ` Gautham R Shenoy
2008-10-25 14:23     ` Paul E. McKenney
2008-10-27 13:21       ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081027132159.GF25371@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).