LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: sniper <s3c24xx@gmail.com>
Cc: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks()
Date: Tue, 28 Oct 2008 09:29:20 +0100	[thread overview]
Message-ID: <20081028082920.GK15734@elte.hu> (raw)
In-Reply-To: <9bd6b5360810271303teb198dejde3116f69cfffd46@mail.gmail.com>


* sniper <s3c24xx@gmail.com> wrote:

> When we failed to get tasklist_lock eventually (count equals 0),
> we should only print " ignoring it.\n", and not print
> " locked it.\n" needlessly.

well spotted!

Minor nit:

> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -3417,10 +3417,12 @@ retry:
>  		}
>  		printk(" ignoring it.\n");
>  		unlock = 0;
> +		goto print_locks;
>  	}
>  	if (count != 10)
>  		printk(" locked it.\n");
> 
> +print_locks:
>  	do_each_thread(g, p) {

please move the "if (count != 10)" line into the else section of the 
trylock, instead of introducing a label and a goto.

	Ingo

  reply	other threads:[~2008-10-28  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 20:03 sniper
2008-10-28  8:29 ` Ingo Molnar [this message]
2008-10-28  9:24   ` qinghuang feng
2008-10-28  9:31     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081028082920.GK15734@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=s3c24xx@gmail.com \
    --subject='Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).