LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
	Andrew Victor <linux@maxim.org.za>
Subject: Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's not needed
Date: Tue, 28 Oct 2008 09:20:19 -0700	[thread overview]
Message-ID: <200810280920.19864.david-b@pacbell.net> (raw)
In-Reply-To: <20081028124526.6b9ccdf5@hskinnemo-gx745.norway.atmel.com>

On Tuesday 28 October 2008, Haavard Skinnemoen wrote:
> David Brownell <david-b@pacbell.net> wrote:
> > From: David Brownell <dbrownell@users.sourceforge.net>
> > 
> > The atmel_serial driver is mismanaging its clock by leaving it on
> > at all times ... the whole point of clock management is to leave
> > it off unless it's actively needed, which conserves power!!
> > 
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> Hmm...the only remaining clk_enable() is in atmel_serial_pm(). Is that
> really enough?
> 
> It looks like the serial core calls ->pm() to power the port up before
> doing anything that might touch the registers, but I can't see that the
> console layer does the same thing...

I verified it on AT91, where the console is normally DBGU and the
other USARTs do get an open().

Didn't verify on AVR32, since 2.6.28-rc can't see the root FS because
of that NOR flash problem.  Though I suppose I can try it on an older
kernel.

As a rule the boot loader will be using that USART, and thus will
have enabled its clock.  :)

- Dave


> 
> Haavard
> 
> 



  reply	other threads:[~2008-10-28 16:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 21:06 David Brownell
2008-10-28 11:45 ` Haavard Skinnemoen
2008-10-28 16:20   ` David Brownell [this message]
2008-10-28 16:37     ` Haavard Skinnemoen
2008-10-28 17:08       ` David Brownell
2008-10-28 17:48         ` Haavard Skinnemoen
2008-10-28 18:41     ` Andrew Victor
2008-10-28 19:51       ` David Brownell
2008-10-29 10:08         ` Haavard Skinnemoen
2008-10-29 15:54           ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810280920.19864.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@rfo.atmel.com \
    --subject='Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it'\''s not needed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).