LKML Archive on
help / color / mirror / Atom feed
From: KAMEZAWA Hiroyuki <>
To: Gerald Schaefer <>
Cc: Dave Hansen <>,,,,,,
Subject: Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated()
Date: Tue, 28 Oct 2008 09:32:24 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1225130369.20384.33.camel@localhost.localdomain>

On Mon, 27 Oct 2008 18:59:29 +0100
Gerald Schaefer <> wrote:
> Instead of using pfn_to_page() you could also have just called
> > __first_valid_page() again.  But, that would have duplicated a bit of
> > work, even though not much in practice because the caches are still hot.
> > 
> > Technically, you wouldn't even need to check the return from
> > __first_valid_page() since you know it has a valid result because you
> > made the exact same call a moment before.
> > 
> > Anyway, can you remove the !page check, fix up the changelog and resend?
> Calling __first_valid_page() again might be a good idea. Thinking about it
> now, I guess there is still a problem left with my patch, but for reasons
> other than what you said :) If the loop is completed with page == NULL,
> we will return -EBUSY with the new patch. But there may have been valid
> pages before, and only some memory hole at the end. In this case, returning
> -EBUSY would probably be wrong.
> Kamezawa, this loop/function was added by you, what do you think?

I think there is a bug, as you wrote.
 - "pfn" and "end_pfn" (and pfn in the middle of them) can be in different zone on strange machine.

Now: test_pages_isolated() is called in following sequence.
     walk_memory_resource()			# read resource range and get start/end of pfn
         -> chcek_page_isolated_cb()
		-> test_page_isolated().

I think all pages within [start, end) passed to test_pages_isolated() should be in the same zone.

please change this to
         -> check_page_isolated_cb()
                 -> walk_page_range_in_same_zone()  # get page range in the same zone.
                        -> test_page_isolated().

Could you try ?


  reply	other threads:[~2008-10-28  0:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 16:49 Gerald Schaefer
2008-10-27 17:17 ` Gerald Schaefer
2008-10-27 17:19 ` Gerald Schaefer
2008-10-27 17:25 ` Dave Hansen
2008-10-27 17:59   ` Gerald Schaefer
2008-10-28  0:32     ` KAMEZAWA Hiroyuki [this message]
2008-10-28 13:00       ` Gerald Schaefer
2008-10-29 14:25 Gerald Schaefer
2008-10-29 18:00 ` Nathan Fontenot
2008-10-30  0:09 ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] memory hotplug: fix page_zone() calculation in test_pages_isolated()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).