LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ep93xx: fix OHCI DMA mask
@ 2008-10-28  8:19 Matthias Kaehlcke
  2008-10-28 10:11 ` Ben Dooks
  0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2008-10-28  8:19 UTC (permalink / raw)
  To: kernel; +Cc: rmk, linux-kernel, akpm

ep93xx: Fix OHCI DMA mask

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>

--

--- linux-2.6.27.org/arch/arm/mach-ep93xx/core.c	2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.27/arch/arm/mach-ep93xx/core.c	2008-10-28 08:05:53.000000000 +0100
@@ -26,6 +26,7 @@
 #include <linux/serial_core.h>
 #include <linux/device.h>
 #include <linux/mm.h>
+#include <linux/dma-mapping.h>
 #include <linux/time.h>
 #include <linux/timex.h>
 #include <linux/delay.h>
@@ -450,12 +451,13 @@
 	},
 };
 
+
 static struct platform_device ep93xx_ohci_device = {
 	.name		= "ep93xx-ohci",
 	.id		= -1,
 	.dev		= {
-		.dma_mask		= (void *)0xffffffff,
-		.coherent_dma_mask	= 0xffffffff,
+		.dma_mask		= &ep93xx_ohci_device.dev.coherent_dma_mask,
+		.coherent_dma_mask	= DMA_BIT_MASK(32),
 	},
 	.num_resources	= ARRAY_SIZE(ep93xx_ohci_resources),
 	.resource	= ep93xx_ohci_resources,

-- 
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona

            You can chain me, you can torture me, you can even
          destroy this body, but you will never imprison my mind
                            (Mahatma Gandhi)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ep93xx: fix OHCI DMA mask
  2008-10-28  8:19 [PATCH] ep93xx: fix OHCI DMA mask Matthias Kaehlcke
@ 2008-10-28 10:11 ` Ben Dooks
  2008-10-28 17:07   ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2008-10-28 10:11 UTC (permalink / raw)
  To: Matthias Kaehlcke, kernel, rmk, linux-kernel, akpm

On Tue, Oct 28, 2008 at 09:19:50AM +0100, Matthias Kaehlcke wrote:
> ep93xx: Fix OHCI DMA mask
> 
> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>

Did this really have to go to so many people? akpm probably doesn't
need to know of this directly, Russell reads linux-arm-kernel so isn't
really a necessary CC: in this and you missed out the linux-usb list.

> --
> 
> --- linux-2.6.27.org/arch/arm/mach-ep93xx/core.c	2008-10-10 00:13:53.000000000 +0200
> +++ linux-2.6.27/arch/arm/mach-ep93xx/core.c	2008-10-28 08:05:53.000000000 +0100
> @@ -26,6 +26,7 @@
>  #include <linux/serial_core.h>
>  #include <linux/device.h>
>  #include <linux/mm.h>
> +#include <linux/dma-mapping.h>
>  #include <linux/time.h>
>  #include <linux/timex.h>
>  #include <linux/delay.h>
> @@ -450,12 +451,13 @@
>  	},
>  };
>  
> +
>  static struct platform_device ep93xx_ohci_device = {
>  	.name		= "ep93xx-ohci",
>  	.id		= -1,
>  	.dev		= {
> -		.dma_mask		= (void *)0xffffffff,
> -		.coherent_dma_mask	= 0xffffffff,
> +		.dma_mask		= &ep93xx_ohci_device.dev.coherent_dma_mask,
> +		.coherent_dma_mask	= DMA_BIT_MASK(32),
>  	},
>  	.num_resources	= ARRAY_SIZE(ep93xx_ohci_resources),
>  	.resource	= ep93xx_ohci_resources,
> 
> -- 
> Matthias Kaehlcke
> Embedded Linux Engineer
> Barcelona
> 
>             You can chain me, you can torture me, you can even
>           destroy this body, but you will never imprison my mind
>                             (Mahatma Gandhi)
>                                                                  .''`.
>     using free software / Debian GNU/Linux | http://debian.org  : :'  :
>                                                                 `. `'`
> gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ep93xx: fix OHCI DMA mask
  2008-10-28 10:11 ` Ben Dooks
@ 2008-10-28 17:07   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-10-28 17:07 UTC (permalink / raw)
  To: Ben Dooks; +Cc: Matthias Kaehlcke, kernel, rmk, linux-kernel

On Tue, 28 Oct 2008 10:11:06 +0000 Ben Dooks <ben-linux@fluff.org> wrote:

> On Tue, Oct 28, 2008 at 09:19:50AM +0100, Matthias Kaehlcke wrote:
> > ep93xx: Fix OHCI DMA mask
> > 
> > Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> 
> Did this really have to go to so many people?

It's better than too few!  Bugfixes are important (most important?)
and our lossage rate on patches is scary high.

In particular, please don't chase people's bugfixes off linux-kernel,
because then I won't see them.  I'd guess that somewhere between a
quarter and a half of the bugfixes which I scoop off the list would
otherwise not have been applied.

Spread the wealth!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-28 17:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-28  8:19 [PATCH] ep93xx: fix OHCI DMA mask Matthias Kaehlcke
2008-10-28 10:11 ` Ben Dooks
2008-10-28 17:07   ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).