LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Steven Rostedt <srostedt@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: fix irqs on/off ip tracing
Date: Tue, 28 Oct 2008 11:19:39 +0100	[thread overview]
Message-ID: <20081028101939.GA19628@elte.hu> (raw)
In-Reply-To: <20081028101458.GA4964@osiris.boeblingen.de.ibm.com>


* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> 81d68a96 "ftrace: trace irq disabled critical timings" added wrappers around
> trace_hardirqs_on/off_caller. However these functions use
> __builtin_return_address(0) to figure out which function actually disabled
> or enabled irqs. The result is that we save the ips of trace_hardirqs_on/off
> instead of the real caller. Not very helpful.
> However since the patch from Steven the ip already gets passed. So use that
> and get rid of __builtin_return_address(0) in these two functions.
> 
> Cc: Steven Rostedt <srostedt@redhat.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>  kernel/lockdep.c |   12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)

good catch and nice cleanup, i've applied it to tip/core/urgent, 
thanks Heiko!

	Ingo

      reply	other threads:[~2008-10-28 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 10:14 Heiko Carstens
2008-10-28 10:19 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081028101939.GA19628@elte.hu \
    --to=mingo@elte.hu \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srostedt@redhat.com \
    --subject='Re: [PATCH] lockdep: fix irqs on/off ip tracing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).