LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: "Andrew Victor" <avictor.za@gmail.com>
Cc: "Haavard Skinnemoen" <haavard.skinnemoen@atmel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	"Haavard Skinnemoen" <hskinnemoen@atmel.com>,
	"Nicolas Ferre" <nicolas.ferre@rfo.atmel.com>
Subject: Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's not needed
Date: Tue, 28 Oct 2008 12:51:29 -0700	[thread overview]
Message-ID: <200810281251.30031.david-b@pacbell.net> (raw)
In-Reply-To: <cd73a99e0810281141ief64433u85a55d045346d3fd@mail.gmail.com>

On Tuesday 28 October 2008, Andrew Victor wrote:
> hi David,
> 
> > I verified it on AT91, where the console is normally DBGU and the
> > other USARTs do get an open().
> 
> The DBGU is part of the system peripherals, which are clocked from MCK
> and which is always enabled.

Exactly.


> Therefore I don't think this is a valid test-case.

Not for the oddball case Haavard mentioned, no:  the console port
being something the boot loader wasn't using, which couldn't show
the early boot messages (before console setup) in any case.  Those
kinds of systems aren't especially debuggable (it's JTAG or nothing).

I don't have any issue with getting that fixed too ... but unless
someone has a platform that relies on that case (or can be made to
do so, for testing), then it's hard for me to worry about it!

- Dave


> 
> Regards,
>   Andrew Victor
> 
> 



  reply	other threads:[~2008-10-28 20:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 21:06 David Brownell
2008-10-28 11:45 ` Haavard Skinnemoen
2008-10-28 16:20   ` David Brownell
2008-10-28 16:37     ` Haavard Skinnemoen
2008-10-28 17:08       ` David Brownell
2008-10-28 17:48         ` Haavard Skinnemoen
2008-10-28 18:41     ` Andrew Victor
2008-10-28 19:51       ` David Brownell [this message]
2008-10-29 10:08         ` Haavard Skinnemoen
2008-10-29 15:54           ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810281251.30031.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=avictor.za@gmail.com \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@rfo.atmel.com \
    --subject='Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it'\''s not needed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).