LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Trent Piepho <tpiepho@freescale.com>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	Richard Purdie <rpurdie@rpsys.net>,
	Sean MacLennan <smaclennan@pikatech.com>,
	Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio()
Date: Tue, 28 Oct 2008 18:16:59 +0300	[thread overview]
Message-ID: <20081028151659.GA26444@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <fa686aa40810280753lc555683y5d32da678384438@mail.gmail.com>

On Tue, Oct 28, 2008 at 08:53:11AM -0600, Grant Likely wrote:
> On Tue, Oct 28, 2008 at 8:39 AM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > Can you repost a fixed version with my Ack and Cc: Andrew Morton,
> > Benjamin Herrenschmidt?
> >
> > I think this change should go into the 2.6.28, so that we can
> > write new code on top of new API. Otherwise this change will cause
> > issues in the next merge window.
> 
> While I like this series, it should not be pushed for .28.  The window
> is closed and we are in bug-fix-only mode.

IIRC, we approve API changes in the early -rcs, exactly to avoid build
break issues for the new code (though the API changes themselves are
discouraged).

> Focus on getting it into Ben's -next tree instead.

Would Benjamin apply the USB FHCI driver then? I doubt it.

So, there are options:

1. Either this patch go in into the .28;

2. Or this patch go in _after_ USB FHCI driver, and Trent takes care
   to convert it to the new API. (I'm trying to push the driver since
   2007, I think. Firstly it has GPIO framework dependency, QE GPIO,
   QE Pinmux, FSL GTM dependency, bindings, e.t.c. And now that.
   No, no deal. I quite tired of the dependencies for this driver.)

3. Or we apply my original patch that won't break the API.
   http://lkml.org/lkml/2008/7/25/236
   I still like it better than Trent's patch, exactly because it
   can't break anything.

> That will deal with any merge window
> conflicts.

This won't deal with build breakage because of API changes, which
means I can't submit FHCI driver to Greg, I have to wait for the
API changes applied.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2008-10-28 15:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 23:04 OpenFirmware GPIO LED driver Trent Piepho
2008-10-24 23:08 ` [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio() Trent Piepho
2008-10-24 23:32   ` Grant Likely
2008-10-28 14:39   ` Anton Vorontsov
2008-10-28 14:53     ` Grant Likely
2008-10-28 15:16       ` Anton Vorontsov [this message]
2008-10-28 15:42         ` Grant Likely
2008-10-28 16:56           ` Anton Vorontsov
2008-10-28 17:40             ` Grant Likely
2008-10-30  2:21     ` [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio()A Trent Piepho
2008-10-30 11:15       ` Anton Vorontsov
2008-10-31  2:03         ` [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio() Trent Piepho
2008-11-26 16:20           ` Anton Vorontsov
2008-11-26 21:38             ` Paul Mackerras
2008-11-26 22:31               ` Anton Vorontsov
2008-11-26 22:35               ` Trent Piepho
2008-11-26 22:58                 ` Anton Vorontsov
2008-11-26 23:32                 ` Paul Mackerras
2008-10-24 23:08 ` [PATCH 2/4] leds: Support OpenFirmware led bindings Trent Piepho
2008-10-24 23:50   ` Grant Likely
2008-10-24 23:09 ` [PATCH 3/4] leds: Add option to have GPIO LEDs start on Trent Piepho
2008-10-24 23:59   ` Grant Likely
2008-10-24 23:09 ` [PATCH 4/4] leds: Let GPIO LEDs keep their current state Trent Piepho
2008-10-25  0:04   ` Grant Likely
2008-11-17 14:50   ` Richard Purdie
2008-11-21  1:05     ` Trent Piepho
2008-11-23 12:31       ` Pavel Machek
2008-12-03 10:04         ` Richard Purdie
2008-12-10  4:33           ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081028151659.GA26444@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=rpurdie@rpsys.net \
    --cc=smaclennan@pikatech.com \
    --cc=tpiepho@freescale.com \
    --cc=w.sang@pengutronix.de \
    --subject='Re: [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).