LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem
@ 2008-10-29  1:41 Harvey Harrison
  2008-10-29  3:44 ` Arjan van de Ven
  0 siblings, 1 reply; 4+ messages in thread
From: Harvey Harrison @ 2008-10-29  1:41 UTC (permalink / raw)
  To: Arjan van de Ven; +Cc: Al Viro, LKML

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Arjan, when you added this helper I think you omitted the iomem
annotation.

 include/linux/pci.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index c75b82b..feb4657 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1136,7 +1136,7 @@ static inline void pci_mmcfg_late_init(void) { }
 #endif
 
 #ifdef CONFIG_HAS_IOMEM
-static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
+static inline void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
 {
 	/*
 	 * Make sure the BAR is actually a memory resource, not an IO resource
-- 
1.6.0.3.756.gb776d




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem
  2008-10-29  1:41 [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem Harvey Harrison
@ 2008-10-29  3:44 ` Arjan van de Ven
  0 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2008-10-29  3:44 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Al Viro, LKML

On Tue, 28 Oct 2008 18:41:17 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:

> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Arjan, when you added this helper I think you omitted the iomem
> annotation.

fair enough

Acked-by: Arjan van de Ven <arjan@linux.intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem
  2008-11-02 21:32 Harvey Harrison
@ 2008-11-03 22:33 ` Jesse Barnes
  0 siblings, 0 replies; 4+ messages in thread
From: Jesse Barnes @ 2008-11-03 22:33 UTC (permalink / raw)
  To: Harvey Harrison; +Cc: Arjan van de Ven, LKML

On Sunday, November 2, 2008 1:32 pm Harvey Harrison wrote:
> Acked-by: Arjan van de Ven <arjan@linux.intel.com>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
>  include/linux/pci.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 9194adf..03b0b8c 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1142,7 +1142,7 @@ static inline void pci_mmcfg_late_init(void) { }
>  #endif
>
>  #ifdef CONFIG_HAS_IOMEM
> -static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
> +static inline void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
>  {
>  	/*
>  	 * Make sure the BAR is actually a memory resource, not an IO resource

Applied to my for-linus branch.

Thanks,
Jesse


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem
@ 2008-11-02 21:32 Harvey Harrison
  2008-11-03 22:33 ` Jesse Barnes
  0 siblings, 1 reply; 4+ messages in thread
From: Harvey Harrison @ 2008-11-02 21:32 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: Arjan van de Ven, LKML

Acked-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 include/linux/pci.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/pci.h b/include/linux/pci.h
index 9194adf..03b0b8c 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1142,7 +1142,7 @@ static inline void pci_mmcfg_late_init(void) { }
 #endif
 
 #ifdef CONFIG_HAS_IOMEM
-static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
+static inline void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
 {
 	/*
 	 * Make sure the BAR is actually a memory resource, not an IO resource
-- 
1.6.0.3.756.gb776d




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-03 22:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-29  1:41 [PATCH] pci: annotate return value of pci_ioremap_bar with __iomem Harvey Harrison
2008-10-29  3:44 ` Arjan van de Ven
2008-11-02 21:32 Harvey Harrison
2008-11-03 22:33 ` Jesse Barnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).