LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: torvalds@linux-foundation.org
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH] corruption checker: print the DMI board name on corruption
Date: Wed, 29 Oct 2008 09:27:56 -0700	[thread overview]
Message-ID: <20081029092756.1e441b80@infradead.org> (raw)
In-Reply-To: <20081029091703.47628e54@infradead.org>

Hi Linus,

would you consider merging this patch for 2.6.28 still?
Without this patch, kerneloops.org only gets to see THAT corruption
happens, but doesn't have information about what kind of system the
corruption is happening on.. (which is the useful part to make a
DMI blacklist).

So far we have 1 such report in kerneloops.org but it's useless... no
system information.



>From c66993517ac861964d6968d3672f88b3b69e29ce Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Wed, 29 Oct 2008 09:24:44 -0700
Subject: [PATCH] corruption checker: print the DMI board name on corruption

when the memory corruptor checker hits (as it has done now based on
kerneloops.org data), it would be extremely useful to know the DMI board
name so we can add a blacklist for such a machine... without having to ask
the user for lots of extra info.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 arch/x86/kernel/setup.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 0fa6790..d57fee2 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -697,6 +697,7 @@ void check_for_bios_corruption(void)
 {
 	int i;
 	int corruption = 0;
+	const char *board;
 
 	if (!memory_corruption_check)
 		return;
@@ -715,7 +716,11 @@ void check_for_bios_corruption(void)
 		}
 	}
 
-	WARN(corruption, KERN_ERR "Memory corruption detected in low memory\n");
+	board = dmi_get_system_info(DMI_PRODUCT_NAME);
+	if (!board)
+		board = "";
+	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
+		board);
 }
 
 static void periodic_check_for_corruption(unsigned long data)
-- 
1.5.5.1


  reply	other threads:[~2008-10-29 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 16:17 [PATCH] corruption checker: print the DMI board name Arjan van de Ven
2008-10-29 16:27 ` Arjan van de Ven [this message]
2008-10-29 16:36   ` [PATCH] corruption checker: print the DMI board name on corruption Ingo Molnar
2008-10-30 11:06 ` [PATCH] corruption checker: print the DMI board name Pavel Machek
2008-10-30 13:28   ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029092756.1e441b80@infradead.org \
    --to=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH] corruption checker: print the DMI board name on corruption' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).