LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Aristeu Rozanski <aris@redhat.com>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] NMI watchdog: add support to enable and disable IOAPIC NMI
Date: Wed, 29 Oct 2008 17:50:01 -0700	[thread overview]
Message-ID: <20081029175001.d2f9db9e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20081029203918.GN771@redhat.com>

On Wed, 29 Oct 2008 16:39:19 -0400 Aristeu Rozanski wrote:

> > > > This patch adds support to enable/disable IOAPIC NMI watchdog in runtime via
> > > > procfs.
> > > 
> > > Some info on how to use this, what to write(?) to what file(?) in procfs
> > > would be Very Good to have.
> > 
> >  I gather this is an extension to the existing interface already covering 
> > the local APIC NMI watchdog, which surely ;) must have been documented at 
> > the time it was added.  If it wasn't, then we cannot require it now as a 
> > prerequisite to accept this patch, although such documentation would be 
> > desirable as a separate submission.
> What about (if OK, I'll resubmit in a different thread with proper format):
> 
> ---
>  Documentation/nmi_watchdog.txt |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- linus-2.6.orig/Documentation/nmi_watchdog.txt	2008-10-24 11:41:30.000000000 -0400
> +++ linus-2.6/Documentation/nmi_watchdog.txt	2008-10-29 16:38:12.000000000 -0400
> @@ -69,6 +69,11 @@ to the overall system performance.
>  On x86 nmi_watchdog is disabled by default so you have to enable it with
>  a boot time parameter.
>  
> +It's possible to disable the NMI watchdog in run-time by writing "0" to
> +/proc/sys/kernel/nmi_watchdog. Writing "1" to the same file will re-enable
> +the NMI watchdog. Notice that you still need to use "nmi_watchdog=" parameter
> +in boot time.
> +
>  NOTE: In kernels prior to 2.4.2-ac18 the NMI-oopser is enabled unconditionally
>  on x86 SMP boxes.

OK.  Or update Documentation/filesystems/proc.txt::nmi_watchdog
(now that I have found it).

---
~Randy

  reply	other threads:[~2008-10-30  0:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27 16:42 [PATCH 0/2] IOAPIC NMI watchdog fixes Aristeu Rozanski
2008-10-27 16:42 ` [PATCH 1/2] NMI watchdog: add support to enable and disable IOAPIC NMI Aristeu Rozanski
2008-10-29 16:05   ` Randy Dunlap
2008-10-29 19:47     ` Maciej W. Rozycki
2008-10-29 20:39       ` Aristeu Rozanski
2008-10-30  0:50         ` Randy Dunlap [this message]
2008-10-27 16:42 ` [PATCH 2/2] NMI watchdog: disable NMIs on LVT0 in case NMI watchdog is not working Aristeu Rozanski
2008-10-27 16:58 ` [PATCH 0/2] IOAPIC NMI watchdog fixes Maciej W. Rozycki
2008-10-27 17:45   ` Ingo Molnar
2008-12-15 11:23   ` Aristeu Rozanski
2008-12-16 15:04     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029175001.d2f9db9e.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=aris@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH 1/2] NMI watchdog: add support to enable and disable IOAPIC NMI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).