LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Arjan van de Ven <arjan@infradead.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] corruption checker: print the DMI board name
Date: Thu, 30 Oct 2008 12:06:53 +0100	[thread overview]
Message-ID: <20081030110653.GA7291@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20081029091703.47628e54@infradead.org>

> 
> >From 4f829eef5a31b68a0cbaf83a75ac8b0a1ed05afb Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Wed, 29 Oct 2008 09:13:23 -0700
> Subject: [PATCH] corruption checker: print the DMI board name
> 
> when the memory corruptor checker hits (as it has done now based on kerneloops.org data),
> it would be extremely useful to know the DMI board name so we can add a blacklist for
> such a machine... without having to ask the user for lots of extra info.

I'm not sure if blacklisting whole brand for one case of bit
corruption is fair -- perhaps the memory was overheating?

  
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

But ACK -- we certainly want to see the data.

> ---
>  arch/x86/kernel/check.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
> index 2ac0ab7..f952182 100644
> --- a/arch/x86/kernel/check.c
> +++ b/arch/x86/kernel/check.c
> @@ -2,6 +2,7 @@
>  #include <linux/sched.h>
>  #include <linux/kthread.h>
>  #include <linux/workqueue.h>
> +#include <linux/dmi.h>
>  #include <asm/e820.h>
>  #include <asm/proto.h>
>  
> @@ -113,6 +114,7 @@ void check_for_bios_corruption(void)
>  {
>  	int i;
>  	int corruption = 0;
> +	const char *board;
>  
>  	if (!memory_corruption_check)
>  		return;
> @@ -131,7 +133,11 @@ void check_for_bios_corruption(void)
>  		}
>  	}
>  
> -	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\n");
> +	board = dmi_get_system_info(DMI_PRODUCT_NAME);
> +	if (!board)
> +		board = "";
> +	WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\nBoard name: %s\n",
> +		board);
>  }
>  
>  static void check_corruption(struct work_struct *dummy);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2008-10-30 11:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 16:17 Arjan van de Ven
2008-10-29 16:27 ` [PATCH] corruption checker: print the DMI board name on corruption Arjan van de Ven
2008-10-29 16:36   ` Ingo Molnar
2008-10-30 11:06 ` Pavel Machek [this message]
2008-10-30 13:28   ` [PATCH] corruption checker: print the DMI board name Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030110653.GA7291@atrey.karlin.mff.cuni.cz \
    --to=pavel@suse.cz \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH] corruption checker: print the DMI board name' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).