LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][v3] blktrace: conversion to tracepoints
Date: Thu, 30 Oct 2008 12:11:45 +0100	[thread overview]
Message-ID: <20081030111144.GQ31673@kernel.dk> (raw)
In-Reply-To: <20081030110352.GB25056@ghostprotocols.net>

On Thu, Oct 30 2008, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 30, 2008 at 08:31:34AM +0100, Jens Axboe escreveu:
> > On Wed, Oct 29 2008, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Oct 29, 2008 at 02:18:55PM +0100, Jens Axboe escreveu:
> > > > > 	Feel free to point any disgusting aspect, perhaps there is at
> > > > > least one to warn me about fixing 8-)
> > > > 
> > > > You my as well pass the members separately now that it's a specific call
> > > > anyway, to avoid doing the calculation when tracing is disabled.
> > > > 
> > > > Patch looks straight forward. Perhaps it would be cleaner to use an
> > > > atomic type for the reference?
> > > 
> > > Done and made the old pdu_int + NULL bio (trace_block_unplug_{io,timer})
> > > functions to receive just the request_queue.
> > > 
> > > Found and fixed a bug in the process:
> > > 
> > > In v2 we had:
> > > 
> > > +       unregister_trace_block_rq_insert(blk_add_trace_rq_insert);
> > > +       unregister_trace_block_rq_insert(blk_add_trace_rq_abort);
> > > 
> > > Where it should have been:
> > > 
> > > +       unregister_trace_block_rq_insert(blk_add_trace_rq_insert);
> > > +       unregister_trace_block_rq_abort(blk_add_trace_rq_abort);
> > > 
> > > c'n'p roblem!
> > > 
> > > Also removed the leftover tracepoint_synchronize_unregister macro, it
> > > was already merged righfully as an inline function.
> > > 
> > > Everything should be rock solid now 8)
> > 
> > I'll apply this for 2.6.29. I'm assuming you have tested this as well?
> 
> Yes, I tested it, run 'btrace /dev/sda' several times, while doing a
> 45 GB backup using rsync over NFS, etc. So it should have exercised the
> tracepoints use and repeated registrater/unregister cycles.

Awesome, just wanted to know what level of testing you had done (from
"none" to "doesn't crash" to "actually works"), so thanks for that.

-- 
Jens Axboe


  reply	other threads:[~2008-10-30 11:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 12:05 [PATCH][v2] " Arnaldo Carvalho de Melo
2008-10-29 13:18 ` Jens Axboe
2008-10-29 15:50   ` Arnaldo Carvalho de Melo
2008-10-29 19:43   ` [PATCH][v3] " Arnaldo Carvalho de Melo
2008-10-30  7:31     ` Jens Axboe
2008-10-30 11:03       ` Arnaldo Carvalho de Melo
2008-10-30 11:11         ` Jens Axboe [this message]
2008-11-03 17:21           ` Arnaldo Carvalho de Melo
2008-11-03 17:22             ` Jens Axboe
2008-11-03 18:08               ` Arnaldo Carvalho de Melo
2008-11-07 14:29       ` Alan D. Brunelle
2008-11-07 14:32         ` Jens Axboe
2008-11-07 15:38           ` Arnaldo Carvalho de Melo
2008-10-30 14:44     ` [PATCH][v3] blktrace: conversion to tracepoints 2.6.27.4 backport Mathieu Desnoyers
2008-10-30 14:47       ` Arnaldo Carvalho de Melo
2008-10-29 15:17 ` [PATCH][v2] blktrace: conversion to tracepoints Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030111144.GQ31673@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=acme@redhat.com \
    --cc=compudj@krystal.dyndns.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH][v3] blktrace: conversion to tracepoints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).