LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: i2c: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Thu, 30 Oct 2008 14:12:53 +0100	[thread overview]
Message-ID: <20081030141253.6405b739@hyperion.delvare> (raw)
In-Reply-To: <1225330161.5970.86.camel@nga.site>

Hi Kay,

On Thu, 30 Oct 2008 02:29:21 +0100, Kay Sievers wrote:
> This patch is part of a larger patch series which will remove
> the "char bus_id[20]" name string from struct device. The device
> name is managed in the kobject anyway, and without any size
> limitation, and just needlessly copied into "struct device".
> 
> To set and read the device name dev_name(dev) and dev_set_name(dev)
> must be used. If your code uses static kobjects, which it shouldn't
> do, "const char *init_name" can be used to statically provide the
> name the registered device should have. At registration time, the
> init_name field is cleared, to enforce the use of dev_name(dev) to
> access the device name at a later time.
> 
> We need to get rid of all occurrences of bus_id in the entire tree
> to be able to enable the new interface. Please apply this patch,
> and possibly convert any remaining remaining occurrences of bus_id.

OK, I'll convert all other users under drivers/i2c.

> We want to submit a patch to -next, which will remove bus_id from
> "struct device", to find the remaining pieces to convert, and finally
> switch over to the new api, which will remove the 20 bytes array
> and does no longer have a size limitation.
>
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: i2c: struct device - replace bus_id with dev_name(), dev_set_name()
> 
> Cc: Jean Delvare <khali@linux-fr.org>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
> ---
> 
> 
> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
> index 5a485c2..ce3cd48 100644
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -459,7 +459,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
>  		pr_debug("I2C adapter driver [%s] forgot to specify "
>  			 "physical device\n", adap->name);
>  	}
> -	sprintf(adap->dev.bus_id, "i2c-%d", adap->nr);
> +	dev_set_name(&adap->dev, "i2c-%d", adap->nr);
>  	adap->dev.release = &i2c_adapter_dev_release;
>  	adap->dev.class = &i2c_adapter_class;
>  	res = device_register(&adap->dev);
> @@ -845,8 +845,7 @@ int i2c_attach_client(struct i2c_client *client)
>  	} else
>  		client->dev.release = i2c_client_dev_release;
>  
> -	snprintf(&client->dev.bus_id[0], sizeof(client->dev.bus_id),
> -		"%d-%04x", i2c_adapter_id(adapter), client->addr);
> +	dev_set_name(&client->dev, "%d-%04x", i2c_adapter_id(adapter), client->addr);
>  	res = device_register(&client->dev);
>  	if (res)
>  		goto out_err;
> @@ -856,7 +855,7 @@ int i2c_attach_client(struct i2c_client *client)
>  	mutex_unlock(&adapter->clist_lock);
>  
>  	dev_dbg(&adapter->dev, "client [%s] registered with bus id %s\n",
> -		client->name, client->dev.bus_id);
> +		client->name, dev_name(&client->dev));
>  
>  	if (adapter->client_register)  {
>  		if (adapter->client_register(client)) {
> 
> 

Applied, with 2 checkpatch fixes, thanks.

-- 
Jean Delvare

      reply	other threads:[~2008-10-30 13:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30  1:29 Kay Sievers
2008-10-30 13:12 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030141253.6405b739@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: i2c: struct device - replace bus_id with dev_name(), dev_set_name()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).